1686331 - (regression) library panel has a scrollbar

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Sören Hentzschel]

The library panel has a scrollbar for no obvious reason. According to mozregression it's a regression from bug 1685133. I don't know why this change should affect the library menu but I executed mozregression two times to be sure and the result was the same.

0:37.25 INFO: Got as far as we can go bisecting nightlies...
0:37.25 INFO: Last good revision: e7ad4ad7c65b441e3cd8e5845ff84df4a28de210 (2021-01-08)
0:37.25 INFO: First bad revision: 87c24c64eece98464a05f684742798f2c9ae00de (2021-01-09)
0:37.25 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7ad4ad7c65b441e3cd8e5845ff84df4a28de210&tochange=87c24c64eece98464a05f684742798f2c9ae00de

Tested on macOS 11.1.

Comment 1

[Sören Hentzschel]

Attachment: screenshot

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Sören Hentzschel from comment #0)

The library panel has a scrollbar for no obvious reason.

My guess is that the code added to browser/components/customizableui/content/panelUI.js in the regressing patch slows down layout enough that the window sizes before we have the contents populated.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking as it seems to be a visible issue for end users and we are approaching the beta merge. Erica, do you have an opinion on this bug? Is that a cross-platform bug or only mac?

Comment 4

[Erica Wright [:ewright]]

looking into it now. I think it is a pretty easy CSS change. Odd that it happened though. I will assign myself.

Comment 5

[Erica Wright [:ewright]]

(In reply to Pascal Chevrel:pascalc from comment #3)

Tracking as it seems to be a visible issue for end users and we are approaching the beta merge. Erica, do you have an opinion on this bug? Is that a cross-platform bug or only mac?
@pascal - there is no scroll bar when the experimental pref is off, so this is less concerning. Note that this pref will remain off for 86 except for experiments.

Comment 6

[Erica Wright [:ewright]]

Attachment: Bug 1686331 - Library menu should not have a scroll bar.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/775a35e213ab
Library menu should not have a scroll bar. r=prathiksha,flod

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/775a35e213ab