Closed Bug 1686353 Opened 2 months ago Closed 2 months ago

Remove defer() from devtools/shared/protocol/Front.js

Categories

(DevTools :: Framework, task)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/devtools/shared/protocol/Front.js#281

This should use new Promise(), and the promise, resolve or reject methods should be passed around differently.

hello, can I work on this bug?

(In reply to Falguni Islam from comment #1)

hello, can I work on this bug?

Sure, feel free to submit a patch, and the task will automatically assigned to you. (Btw, in the future, you don't need to ask unless someone is explicitly working on it).

If you need any help, please let us know by using the "Request information from" field.

I'm not sure we can get rid of defer here as the code is quite complex

Per conversation with Nicolas, removing defer() won't make things cleaner here, unless there is a significant refactor.
Closing this bug.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.