Closed
Bug 1686395
Opened 3 years ago
Closed 3 years ago
Remove [Un]RegisterAccessKey calls in frame code
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
87 Branch
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
Some form control frames still call nsCheckboxRadioFrame::RegUnRegAccessKey
manually to register accesskey
s. This is unnecessary since we now do that globally for all elements in nsGenericHTMLElement::BindToTree/UnbindFromTree
:
https://searchfox.org/mozilla-central/rev/014fe72eaba26dcf6082fb9bbaf208f97a38594e/dom/html/nsGenericHTMLElement.cpp#441,480
Assignee | ||
Comment 1•3 years ago
|
||
Depends on D101555
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f95f2b3ea92 Remove [Un]RegisterAccessKey calls in frame code (idempotent change). r=emilio
Comment 3•3 years ago
|
||
Backed out for conflicting with the backout of Bug 1683748
Backout link: https://hg.mozilla.org/integration/autoland/rev/f262a5526f6ce10fd4c23f0b2bee7eba48872432
Flags: needinfo?(mats)
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00b99054a84d Remove [Un]RegisterAccessKey calls in frame code (idempotent change). r=emilio
Comment 5•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(mats)
You need to log in
before you can comment on or make changes to this bug.
Description
•