1686492 - Implement "Give %TypedArray% methods explicit algorithms" spec PR

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[André Bargull [:anba]]

Implement the changes from https://github.com/tc39/ecma262/pull/2221.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 1: Update test262. r=mgaudet!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 2: Update test262 exclusion list. r=mgaudet!

Depends on D101609

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 3: Update TypedArray.prototype.every(). r=mgaudet!

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101611

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 4: Update TypedArray.prototype.find(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101612

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 5: Update TypedArray.prototype.findIndex(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101613

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 6: Update TypedArray.prototype.forEach(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101614

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 7: Update TypedArray.prototype.includes(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and adds an assertion which was added to the spec.
Otherwise no change in behaviour.

Depends on D101615

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 8: Update TypedArray.prototype.indexOf(). r=mgaudet!

Updates the step references and adds an assertion which was added to the spec.

The updated spec wants us to perform a HasProperty check during the loop in
step 11.a. We can avoid this operation when we instead re-read the TypedArray
length after steps 5-6.

Depends on D101616

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 9: Update TypedArray.prototype.join(). r=mgaudet!

Updates the step references.

The updated spec wants us to perform a comparison against undefined during the
loop in step 8.c. We can avoid this operation when we instead re-read the
TypedArray length after steps 4-5.

Depends on D101617

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 10: Update TypedArray.prototype.lastIndexOf(). r=mgaudet!

Similar to the changes in part 8:

Updates the step references.

The updated spec wants us to perform a HasProperty check during the loop in
step 9.a. We can avoid this operation when we instead re-read the TypedArray
length after step 5.

Depends on D101618

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 11: Update TypedArray.prototype.reduce(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101620

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 12: Update TypedArray.prototype.reduceRight(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101621

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 13: Update TypedArray.prototype.reverse(). r=mgaudet!

Similar changes as in part 3:

Updates the step references. Otherwise no change in behaviour.

Depends on D101622

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 14: Update TypedArray.prototype.some(). r=mgaudet!

Similar changes as in part 3:

Updates the step references and renames the T variable to thisArg to match
the current spec. Otherwise no change in behaviour.

Depends on D101623

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1686492 - Part 15: Enable now passing test262 tests. r=mgaudet!

Depends on D101624

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab8ccb6f156
Part 1: Update test262. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a31a4f8b7b7b
Part 2: Update test262 exclusion list. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/af449dd0f569
Part 3: Update TypedArray.prototype.every(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d22011319413
Part 4: Update TypedArray.prototype.find(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a62daed85eba
Part 5: Update TypedArray.prototype.findIndex(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ab607b7aff5e
Part 6: Update TypedArray.prototype.forEach(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d58e9af14665
Part 7: Update TypedArray.prototype.includes(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/dcfc69d91d0c
Part 8: Update TypedArray.prototype.indexOf(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9d36931d65ef
Part 9: Update TypedArray.prototype.join(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/21d8458092c3
Part 10: Update TypedArray.prototype.lastIndexOf(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/60dee0bedf76
Part 11: Update TypedArray.prototype.reduce(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b582661145b2
Part 12: Update TypedArray.prototype.reduceRight(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ae8abd27947d
Part 13: Update TypedArray.prototype.reverse(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d4563c204dc1
Part 14: Update TypedArray.prototype.some(). r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/14223d174bac
Part 15: Enable now passing test262 tests. r=mgaudet

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2ab8ccb6f156
https://hg.mozilla.org/mozilla-central/rev/a31a4f8b7b7b
https://hg.mozilla.org/mozilla-central/rev/af449dd0f569
https://hg.mozilla.org/mozilla-central/rev/d22011319413
https://hg.mozilla.org/mozilla-central/rev/a62daed85eba
https://hg.mozilla.org/mozilla-central/rev/ab607b7aff5e
https://hg.mozilla.org/mozilla-central/rev/d58e9af14665
https://hg.mozilla.org/mozilla-central/rev/dcfc69d91d0c
https://hg.mozilla.org/mozilla-central/rev/9d36931d65ef
https://hg.mozilla.org/mozilla-central/rev/21d8458092c3
https://hg.mozilla.org/mozilla-central/rev/60dee0bedf76
https://hg.mozilla.org/mozilla-central/rev/b582661145b2
https://hg.mozilla.org/mozilla-central/rev/ae8abd27947d
https://hg.mozilla.org/mozilla-central/rev/d4563c204dc1
https://hg.mozilla.org/mozilla-central/rev/14223d174bac