The new non-native widget theme doesn't have any padding between blinking cursor & border, in a textfield / textarea
Categories
(Core :: Widget, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: dholbert, Assigned: emilio)
References
Details
Attachments
(4 files, 1 obsolete file)
STR:
- Run Firefox with about:config
widget.disable-native-theme-for-content
set totrue
. - View attached testcase (just a textarea and a textfield)
- Focus either of the form controls in the testcase.
ACTUAL RESULTS:
The blinking cursor is flush with (or maybe even overlaps?) the top and bottom border of the text field. This makes it look a bit misaligned / overflowing.
EXPECTED RESULTS:
There should be a little bit of blank padding-area between the blinking cursor and the border, to visually separate them.
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
Reporter | ||
Comment 3•4 years ago
|
||
Reporter | ||
Comment 4•4 years ago
|
||
ni=spohl to weigh in on this (e.g. maybe my expectations don't match our design-spec on this, not sure)
Note: these elements seem to have 1px of padding on the top and bottom and 4px of padding on the sides (via a UA stylesheet). If I instead restyle them to use 2px of padding on the top and bottom, then that essentially fixes this; it gives enough visual separation between the cursor and the border.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 5•4 years ago
|
||
(tangent: while playing around with padding, I noticed another issue & filed it as bug 1686613)
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Tracking non-native theming bugs for Fission Beta milestone (M7).
Comment 7•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 8•4 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #4)
ni=spohl to weigh in on this (e.g. maybe my expectations don't match our design-spec on this, not sure)
It is true that this doesn't match our design-spec, but we should adjust this when necessary. This bug certainly warrants another look. I have posted a patch that increases the top and bottom padding to 2px as suggested.
Assignee | ||
Comment 9•4 years ago
|
||
Outline should by default start outside of the border area, not inside.
Then we can use negative outline offsets to cover the border if we want
to.
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 11•4 years ago
|
||
bugherder |
Reporter | ||
Comment 12•4 years ago
|
||
Hmm, it looks like this is fixed for <input> (yay!) but not for <textarea> -- the cursor is still flush with the top of the textarea for me, in the attached testcase (it looks like the screenshot in comment 3).
I'll file a followup for that.
Reporter | ||
Comment 13•4 years ago
|
||
(ni? just as an FYI, in case the fix was expected to catch textarea as well.)
Reporter | ||
Comment 14•4 years ago
|
||
(er, transfering needinfo to new bug. Sorry for spam.)
Description
•