Closed Bug 1686715 Opened 4 years ago Closed 4 years ago

[Automated review] Deleting files without test coverage gets flagged as violation of testing policy

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P4)

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1662606

People

(Reporter: ytausky, Unassigned)

Details

Phabricator URL: https://phabricator.services.mozilla.com/D101632

In this revision I'm deleting several files of dead code, yet the automatic analysis sees that as merely modifying them and suggests I either add tests or remove the files (which is what I'm doing).

marco does it ring a bell?

Flags: needinfo?(mcastelluccio)

We should detect when files are being removed and avoid printing the warning in that case, it doesn't make sense to show it (it doesn't hurt, but it doesn't add any value either).

Flags: needinfo?(mcastelluccio)
Priority: -- → P4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.