168688 - cmd-l spawns new window instead of putting focus in addressbar

Status: VERIFIED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[Neil Lee [:neilio]]

I've noticed that after running Navigator for a bit, cmd-l spawns a new window
instead of putting focus into the address bar. If I quit and restart or create a
new window (cmd-n), the problem disappears for a while but returns.

Sorry this isn't more detailed but I haven't been able to reliably reproduce
this. I'll update if I can..

Build 2002091405

Comment 1

[Neil Lee [:neilio]]

Okay, I can reproduce this now:

i) click on a link that spawns a new window (via the 'target' attribute).
ii) with the new window in front, hit cmd-l to put focus into address bar.
iii) the new window doesn't get focus - the original one does.
iv) even if you close the first window, hitting cmd-l in the new window
continues to spawn new windows instead of putting focus in the address bar of
the original window as expected.

I can get this to reproduce every time.

Comment 2

[Greg K.]

Confirmed using Chimera/2002090913 on 10.1.5. Reassigning to Accessibility.
Probably a dup of bug 168369.

Comment 3

[Ken W]

I have noticed this for a while, but just thought to look for a bug before I reported it myself.  I am still noticing this under 10.2 with the 10/23/02 Chimera nightly build.

Comment 4

[sairuh (rarely reading bugmail)]

i can repro this using the recipe in comment 1.

bryner, do you think this is the same as bug 168369?

Comment 5

[sairuh (rarely reading bugmail)]

->sfraser

Comment 6

[Michael Lam]

Attachment: Patch fixing 168688

The bug happens when a new window is generated from a old window using the
following sample tag
<a href="www.abc.com" target="new">

The Chrome of the new window is something other than the default chrome. As a
result, the function "getFrontmostBrowserWindow" will continue to search for
the next window until it found a window that is with default chrome.

The new patch will use the window with key focus [windowController keyWindow]
instead, and checks if that window is of type BrowserWindow, and if the window
has toolbar, statusbar and is resizable. If the above criteria is true, then
the frontmost window will be returned, otherwise, it returns NULL so that CMD-L
will open a new window.

Comment 7

[Michael Lam]

Comment on attachment 105021 [details] [diff] [review]
Patch fixing 168688

This patch has a bug, I'll just obsolete it and attach another one.

Comment 8

[Michael Lam]

Attachment: Patch fixing 168688

The previous patch has a problem that makes Chimera not remembering its latest
window position. This patch will just behaves like Chimera has worked before
(searching through the array of window to find the appropiate one), with the
addition of checking if the browser has a toolbar, a statusbar and is
resizable, then the window can become the front window.

Comment 9

[Simon Fraser [no longer active]]

The spirit of the patch looks good. Please attach a unified diff with lots of
context (cvs diff -u8).

Comment 10

[Simon Fraser [no longer active]]

*** Bug 168369 has been marked as a duplicate of this bug. ***

Comment 11

[Michael Lam]

I don't understand what is a 'unified diff with lots of context', could you tell me more on how to 
do it?

Comment 12

[Simon Fraser [no longer active]]

'man diff' will tell you. Assuming you're building from cvs, this will also give
you a unified diff with 8 lines of context:

cvs diff -u8

Comment 13

[Michael Lam]

Attachment: Unified diff patch

Unified diff attached here.

Comment 14

[saari (gone)]

*** Bug 178198 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Pinkerton (not reading bugmail)]

i landed this this morning. tried a few of the duplicate bugs and cmd-l focuses
the urlbar in the correct (spawned) window.

Comment 16

[Mike Pinkerton (not reading bugmail)]

*** Bug 176252 has been marked as a duplicate of this bug. ***

Comment 17

[Mike Pinkerton (not reading bugmail)]

*** Bug 171041 has been marked as a duplicate of this bug. ***

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.11.06.04 on 10.2.1. tested with both icon and text-only
toolbars (to test sheet aspect), and also test other commands (cmd-L, cmd-/,
cmd-B, cmd-F, accessing bookmarks from menubar).

Comment 19

[Ken W]

Awesome.  Thanks for all the work on this.

Comment 20

[Mike Pinkerton (not reading bugmail)]

*** Bug 162028 has been marked as a duplicate of this bug. ***