1686910 - Bad handling of non-existent origin directory in SaveOriginAccessTimeOp::DoDirectoryWork

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect)

Description

[Simon Giesecke [:sg] [he/him]]

https://searchfox.org/mozilla-central/rev/2a24205479519e70c0574929f45730d285141584/dom/quota/ActorsParent.cpp#8282 appears to expect that GetBinaryOutputStream returns nullptr in case of a non-existent file. However, it return a NS_ERROR_UNEXPECTED in that case. Since that doesn't allow to discriminate between a non-existent file and other errors without ambiguity, it should probably check for existence of the file before trying to open it. The comment above the line confusingly refers to existence of the origin directory. This should also be adjusted, and resolve the implicit assumption that existence of the origin directory and of the metadata file are equivalent.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1686910 - Check for existence of origin directory explicitly in SaveOriginAccessTimeOp::DoDirectoryWork. r=#dom-workers-and-storage

Comment 2

[Jan Varga [:janv]]

This might fix bug 1582384, bug 1582385, bug 1582386 and bug 1582387.

Comment 3

[Jens Stutte [:jstutte]]

(In reply to Jan Varga [:janv] from comment #2)

This might fix bug 1582384, bug 1582385, bug 1582386 and bug 1582387.

Once this lands we should have a look at those bugs, thus marking them as blocked.

Comment 4

[Simon Giesecke [:sg] [he/him]]

I wonder what tool produces/tracks these warning counts?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acd57716ac6d
Check for existence of origin directory explicitly in SaveOriginAccessTimeOp::DoDirectoryWork. r=dom-workers-and-storage-reviewers,janv

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/acd57716ac6d