1687034 - Global Search icon appears in the Mail Toolbar with Global Search disabled

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[WaltS48 [:walts48]]

Attachment: search-icon.png

Open Thunderbird
Open Options > General
Scroll down to Indexing
Disable Global Search and Indexer
Return to the Mail tab

After bug 1681010 landed with the icon moved to the left the icon always appears in the Mail toolbar with the preference disabled.

The icon should not be on the toolbar.

Comment 1

[Richard Marti (:Paenglab)]

The searchInput is hidden here: https://searchfox.org/comm-central/rev/fcc669d579005225f23557b984fd6d16a4239cb3/mail/base/content/gloda-autocomplete-input.js#84-92. Would it be possible to hide here the .search-icon too?

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1687034_showgloda.patch

I don't think hiding/showing should be the responsibility of the custom element.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9197569 [details] [diff] [review]
bug1687034_showgloda.patch

It works for the main tab but the chat tab has a Gloda search field that needs to be hidden too.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1687034_showgloda.patch

Good catch - and the items can also be customized away.
Testing that I notice the chat one has (since overlay removal 3yrs ago) had &title; showing as the title, so I fixed that as well.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9197586 [details] [diff] [review]
bug1687034_showgloda.patch

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/084beaa47608
hide both Global Search icon and input when Global Search disabled. r=Paenglab

Comment 7

[Magnus Melin [:mkmelin]]

Looking at the regressing bug, I'm not sure it's such a good idea to use a separate image instead of styling the input. Anyway...

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9197586 [details] [diff] [review]
bug1687034_showgloda.patch

[Approval Request Comment]
Regression caused by (bug #): 1681010
User impact if declined: gloda search icon showing in the toolbar when gloda disabled
Testing completed (on c-c, etc.): c-c, soon beta
Risk to taking this patch (and alternatives if risky): low risk

Comment 9

[WaltS48 [:walts48]]

Global search icon no longer appears in the Mail or Chat toolbars with gloda disabled in 86.0b1 build2 Build ID 20210128005905 on Windows 10.

Still present in 78.7.0.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9197586 [details] [diff] [review]
bug1687034_showgloda.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/46bdc748046b

Comment 12

[WaltS48 [:walts48]]

Verified in my test of the 78.7.1 release candidate on Windows 10.