Closed Bug 1687205 Opened 3 years ago Closed 3 years ago

The response is getting the network stacktrace actor id instead of the network event actor id

Categories

(DevTools :: Netmonitor, defect)

defect

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

Details

Attachments

(1 file)

Fixing a test failure here https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_stacktrace_console_initiated_request.js#45 when trying to enable NETWORK_EVENT and NETWORK_EVENT_STACK_TRACE in Bug 1665383

The issue to be fixed is here https://searchfox.org/mozilla-central/rev/6feef3dcfce7e5c922093edde758330857ce2bb3/devtools/client/netmonitor/src/connector/firefox-data-provider.js#530. This currently resolves to something like
{ from: "server0.conn0.netEvent5" stacktrace: [...] } where from is the actor id when getting the network stacktrace. but from should rather be the network event actor.

Blocks: 1665383
Type: enhancement → defect
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68f676381ab4
[devtools] Use the network event actor id when getting stacktraces r=ochameau,devtools-backward-compat-reviewers
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff2076e8d4eb
[devtools] Use the network event actor id when getting stacktraces r=ochameau,devtools-backward-compat-reviewers
Flags: needinfo?(hmanilla)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: