Enable ESLint rule no-setter-return on the rest of the tree
Categories
(Toolkit :: General, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(5 files)
We've enabled the ESLint rule no-setter-return on most of the tree, but there are still some files in the top level .eslintrc.js to be cleaned up.
From the ESLint page:
Setters cannot return values.
While returning a value from a setter does not produce an error, the returned value is being ignored. Therefore, returning a value from a setter is either unnecessary or a possible error, since the returned value cannot be used.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D102152
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D102153
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D102154
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D102155
|
|
Assignee | |
Updated•3 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6eb33ad5d460 Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers https://hg.mozilla.org/integration/autoland/rev/c36493fb0599 Enable ESLint rule no-setter-return for toolkit and services. r=mossop https://hg.mozilla.org/integration/autoland/rev/a7c933ddecfd Enable ESLint rule no-setter-return for devtools. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/ec830b771bce Enable ESLint rule no-setter-return for dom. r=bryce https://hg.mozilla.org/integration/autoland/rev/638c802ca1d1 Enable ESLint rule no-setter-return for mobile/. r=agi
|
||
Comment 7•3 years ago
|
||
Backed out 5 changesets (Bug 1687235) for mochitest failures at test_menulist_null_value.xhtml.
https://hg.mozilla.org/integration/autoland/rev/b8c9fe14dbc331704644346e55eb13bd06c97526
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=afb6bcdbdf4f7345d8b683ca7d3337fcebf27d81&selectedTaskRun=PeFls1X7TnG8MkuJJCyMpg.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=327798640&repo=autoland&lineNumber=7851
|
|
Assignee | |
Comment 8•3 years ago
|
||
Missed keeping in an early return, fixing.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19366accdcb8 Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers https://hg.mozilla.org/integration/autoland/rev/3ba81cd5265d Enable ESLint rule no-setter-return for toolkit and services. r=mossop https://hg.mozilla.org/integration/autoland/rev/dac784daa790 Enable ESLint rule no-setter-return for devtools. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/d674c5489728 Enable ESLint rule no-setter-return for dom. r=bryce https://hg.mozilla.org/integration/autoland/rev/4daf19dcc91b Enable ESLint rule no-setter-return for mobile/. r=agi
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/19366accdcb8
https://hg.mozilla.org/mozilla-central/rev/3ba81cd5265d
https://hg.mozilla.org/mozilla-central/rev/dac784daa790
https://hg.mozilla.org/mozilla-central/rev/d674c5489728
https://hg.mozilla.org/mozilla-central/rev/4daf19dcc91b
Description
•