1687261 - [META] Pass all breakpoints types via the watcher actor

Status: NEW

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Today, only regular breakpoints are passed via the Watcher actor.
This has been done in bug 1573327.
This allows to:

• distribute the breakpoints to all target automatically, thanks for the framework code around the Watcher Actor.
• ensure breakpoints are set before the page/process/thread starts running.

So, this work is especially important in order to have breakpoint fully functional when navigating to another process.

Comment 1

[Alexandre Poirot [:ochameau]]

This may impact the following features:

• pause on exception (+pause on caught exceptions)
• xhr breakpoint (bug 1685105)
• event breakpoint
• dom mutation (not 100% sure, does it work across reloads/navigations?)
• skip breakpoints
• log points

It may be broken either on early loads of remote iframes, or when navigating to a distinct domain/process.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I tested all related breakpoint types, see the summary

Test case:
http://janodvarko.cz/tests/fission/case10/index.html

Pause when page is loaded

• XHR - Broken (bug 1685105)
• DOM Mutation - works for me
• JS Exception - both (caught/uncaught) works for me
• Event BP - works for me
• Log Points - works for me
• Watch Points - works for me
• Skip debugger; keyword - works for me
• Disable all breakpoints - works for me

Pause in onLoad event

• XHR - Broken (bug 1685105)
• DOM Mutation - not persisted across page reload (bug 1571907)
• JS Exception - both (caught/uncaught) works for me
• Event BP - works for me
• Log Points - works for me
• Watch Points - not persisted across page reload (no bug filed)
• Skip debugger; keyword - works for me
• Disable all breakpoints - works for me (there is bug 1592192, but I can't repro)

Honza

Comment 3

[Chris Peterson [:cpeterson]]

DevTools meta bugs don't need to block Fission MVP. However, we will continue to monitor these meta bugs for any new bugs blocking them as potential blockers for Fission MVP.