Closed Bug 1687321 Opened 3 years ago Closed 3 years ago

Reduce code duplication and behaviour variances around directory entry expectations

Categories

(Core :: Storage: Quota Manager, task)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: sg, Assigned: sg)

References

Details

Attachments

(4 files)

Quota manager and its clients should make use of GetDirEntryKind, EnsureDirectory and similar functions rather than individual calls to IsDirectory and Exists.

Similarly, a generic wrapper function template could be added and used for calls to other functions that might end up with the file not existing, such as GetFileSize. See, e.g. https://phabricator.services.mozilla.com/D102206#inline-574934.

Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c73674e14774
Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/cache. r=dom-workers-and-storage-reviewers,janv
Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b0fbffe2432
Fix lint failure in dom/cache/FileUtils.cpp a=lint-fix CLOSED TREE
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b586a830198c
Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/indexedDB. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ddea65cd1d51
Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/localstorage. r=dom-workers-and-storage-reviewers,janv
Keywords: leave-open
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a9070caf537
Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/quota. r=dom-workers-and-storage-reviewers,janv
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: