Reduce code duplication and behaviour variances around directory entry expectations
Categories
(Core :: Storage: Quota Manager, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
Details
Attachments
(4 files)
Quota manager and its clients should make use of GetDirEntryKind
, EnsureDirectory
and similar functions rather than individual calls to IsDirectory
and Exists
.
Assignee | ||
Comment 1•3 years ago
|
||
Similarly, a generic wrapper function template could be added and used for calls to other functions that might end up with the file not existing, such as GetFileSize
. See, e.g. https://phabricator.services.mozilla.com/D102206#inline-574934.
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D103762
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D103763
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D103764
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D103765
Assignee | ||
Updated•3 years ago
|
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c73674e14774 Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/cache. r=dom-workers-and-storage-reviewers,janv
Comment 10•3 years ago
|
||
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b0fbffe2432 Fix lint failure in dom/cache/FileUtils.cpp a=lint-fix CLOSED TREE
Comment 11•3 years ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b586a830198c Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/indexedDB. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/ddea65cd1d51 Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/localstorage. r=dom-workers-and-storage-reviewers,janv
Assignee | ||
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5a9070caf537 Use GetDirEntryKind instead of IsDirectory when iterating over directory entries in dom/quota. r=dom-workers-and-storage-reviewers,janv
Comment 13•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c73674e14774
https://hg.mozilla.org/mozilla-central/rev/6b0fbffe2432
https://hg.mozilla.org/mozilla-central/rev/b586a830198c
https://hg.mozilla.org/mozilla-central/rev/ddea65cd1d51
https://hg.mozilla.org/mozilla-central/rev/5a9070caf537
Description
•