1687380 - window.alert plays sound when `prompts.contentPromptSubDialog=true`

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

1. Open data:text/html,<script>alert("hello")</script>

Expected: No sound
Actual: It sounds on Windows

Comment 1

[:Gijs (he/him)]

Last time we changed tab modal dialogs we broke it in the opposite direction - bug 613806.

I guess https://searchfox.org/mozilla-central/rev/c54c71ecbd9e64cafc0df3b596e206ac4072cb91/toolkit/components/prompts/src/CommonDialog.jsm#218 and its sibling in the select dialog want updating to not fire if loaded in a tab-modal dialog, or something...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1680637

Comment 3

[Emma Malysz]

Attachment: Bug 1687380, ensure we do not play a sound for dialogs loaded in a tab-modal dialog

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60757f7a0c8e
ensure we do not play a sound for dialogs loaded in a tab-modal dialog r=mtigley

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/60757f7a0c8e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc57a286df04
adjust Thunderbird to toolkit/components/prompts/content/selectDialog.js global variable changes. rs=bustage-fix DONTBUILD

Comment 7

[Anca Soncutean, Desktop QA]

Reproduced with Fx 86.0a1 (2021-01-18) on Windows 10.
Verified fixed with Fx 87.0a1 (2021-02-01) and Fx 86.0b4 on Windows 10 and Ubuntu 18.04.