Closed Bug 1687380 Opened 1 month ago Closed 1 month ago

window.alert plays sound when `prompts.contentPromptSubDialog=true`

Categories

(Firefox :: General, defect, P2)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- verified

People

(Reporter: saschanaz, Assigned: emalysz)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-modals])

Attachments

(1 file)

Bug 1687380, ensure we do not play a sound for dialogs loaded in a tab-modal dialog
48 bytes, text/x-phabricator-request
Details | Review
  1. Open data:text/html,<script>alert("hello")</script>

Expected: No sound
Actual: It sounds on Windows

Blocks: proton-modals
Whiteboard: [proton-modals]

Last time we changed tab modal dialogs we broke it in the opposite direction - bug 613806.

I guess https://searchfox.org/mozilla-central/rev/c54c71ecbd9e64cafc0df3b596e206ac4072cb91/toolkit/components/prompts/src/CommonDialog.jsm#218 and its sibling in the select dialog want updating to not fire if loaded in a tab-modal dialog, or something...

See Also: → 613806
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → emalysz
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60757f7a0c8e
ensure we do not play a sound for dialogs loaded in a tab-modal dialog r=mtigley

https://hg.mozilla.org/mozilla-central/rev/60757f7a0c8e

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox86: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fc57a286df04
adjust Thunderbird to toolkit/components/prompts/content/selectDialog.js global variable changes. rs=bustage-fix DONTBUILD
Flags: qe-verify+

Reproduced with Fx 86.0a1 (2021-01-18) on Windows 10.
Verified fixed with Fx 87.0a1 (2021-02-01) and Fx 86.0b4 on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox86: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.