Open Bug 1687385 Opened 4 months ago Updated 2 months ago

Update SeaMonkey mozconfigs

Categories

(SeaMonkey :: Release Engineering, task)

Tracking

(seamonkey2.53? affected, seamonkey2.57esr? affected)

ASSIGNED
Tracking Status
seamonkey2.53 ? affected
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Keywords: leave-open)

Attachments

(2 files, 2 obsolete files)

The mozconfigs in the source tree are out of date.
The plan is to structure them in such a way that:

  • a developer can source mozconfigs/mozconfig.<platform>.common for local building
    and
  • builders can source the relevant file in mozconfigs/<platform>/ for releases/beta

mozconfigs/mozconfig.release and mozconfigs/mozconfig.beta would need to reflect the current application versioning.

Attached patch 1687385-mozconfigs-2537.patch (obsolete) — Splinter Review

Asking for feedback on the structure and Windows platform files are correct.

Attachment #9197830 - Flags: feedback?(frgrahl)

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: out of date mozconfigs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9197830 - Attachment is obsolete: true
Attachment #9197830 - Flags: feedback?(frgrahl)
Attachment #9198916 - Flags: review?(frgrahl)
Attachment #9198916 - Flags: approval-comm-release?

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none, just removing unused files
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9198917 - Flags: review?(frgrahl)
Attachment #9198917 - Flags: approval-comm-release?

Comment on attachment 9198917 [details] [diff] [review]
1687385-tooltool-2537.patch
[checked in comment 5 Target 2.84a1 comment 7 Target 2.53.7 ]

I think the tooltool removal is a no brainer for all our branches and comm-central. r/a+ just needs a bit of a rebasing for 2.57 and central.

Attachment #9198917 - Flags: review?(frgrahl)
Attachment #9198917 - Flags: review+
Attachment #9198917 - Flags: approval-comm-release?
Attachment #9198917 - Flags: approval-comm-release+
Attachment #9198917 - Flags: approval-comm-esr60+
Keywords: leave-open
Version: SeaMonkey 2.53 Branch → Trunk
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d0d105309283
Update SeaMonkey mozconfigs - remove tooltool manifests. r=frg
Attachment #9198917 - Attachment description: WIP-1687385-tooltool-253.patch → 1687385-tooltool-2537.patch [checked in comment 5 Target 2.53.7 2.84a1]
Attachment #9198917 - Attachment filename: WIP-1687385-tooltool-253.patch → 1687385-tooltool-2537.patch

As elf-hack enables automagically for the correct platforms there is no need to have it in explicitly (and incorrectly for macos).

Attachment #9198916 - Attachment is obsolete: true
Attachment #9198916 - Flags: review?(frgrahl)
Attachment #9198916 - Flags: approval-comm-release?
Attachment #9206232 - Flags: review?(frgrahl)
Attachment #9206232 - Flags: approval-comm-release?

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/927d6bdac7d4edcdff95f00c0ee3ab62dd8f1917
Update SeaMonkey mozconfigs - remove tooltool manifests. r=frg a=frg
Target 2.53.7

Attachment #9198917 - Attachment description: 1687385-tooltool-2537.patch [checked in comment 5 Target 2.53.7 2.84a1] → 1687385-tooltool-2537.patch [checked in comment 5 Target 2.84a1 comment 7 Target 2.53.7 ]
You need to log in before you can comment on or make changes to this bug.