1687385 - Update SeaMonkey mozconfigs

Status: ASSIGNED

(SeaMonkey :: Release Engineering, enhancement)

Description

[Ian Neal]

The mozconfigs in the source tree are out of date.
The plan is to structure them in such a way that:

• a developer can source mozconfigs/mozconfig.<platform>.common for local building
  and
• builders can source the relevant file in mozconfigs/<platform>/ for releases/beta

mozconfigs/mozconfig.release and mozconfigs/mozconfig.beta would need to reflect the current application versioning.

Comment 1

[Ian Neal]

Attachment: 1687385-mozconfigs-2537.patch

Asking for feedback on the structure and Windows platform files are correct.

Comment 2

[Ian Neal]

Attachment: WIP-1687385-mozconfigs-v1_1-253.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: out of date mozconfigs
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 3

[Ian Neal]

Attachment: 1687385-tooltool-2537.patch [checked in comment 5 Target 2.84a1 comment 7 Target 2.53.7 ]

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none, just removing unused files
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9198917 [details] [diff] [review]
1687385-tooltool-2537.patch
[checked in comment 5 Target 2.84a1 comment 7 Target 2.53.7 ]

I think the tooltool removal is a no brainer for all our branches and comm-central. r/a+ just needs a bit of a rebasing for 2.57 and central.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0d105309283
Update SeaMonkey mozconfigs - remove tooltool manifests. r=frg

Comment 6

[Ian Neal]

Attachment: WIP-1687385-mozconfigs-v1_2-253.patch

As elf-hack enables automagically for the correct platforms there is no need to have it in explicitly (and incorrectly for macos).

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/927d6bdac7d4edcdff95f00c0ee3ab62dd8f1917
Update SeaMonkey mozconfigs - remove tooltool manifests. r=frg a=frg
Target 2.53.7

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: WIP-1687385-mozconfigs-v2_0-253.patch

Added some stuff from the Windows builder but all an unconsolidated mess. So not asking for freedback yet.

Comment 9

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct-mozconfig.patch

Took the information from working builds on the builders and placed the different options in different files.

Missing are the nightly ones. The debug ones are there but haven't fixed them yet. (We haven't really made a debug build in some time).

Also, in the past, there were l10n-release mozconfigs, but do not quite remember how they were used, so skipping them.

Comment 10

[Edmund Wong (:ewong)]

Fwiw... I have tried the builds and they work in automation.

Comment 11

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

Updated patch. frg wanted the scripts to be kept for reference. Placed them in config/scripts

Comment 12

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

Fixed the beta mozconfigs for mac

Comment 13

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

missed a few scripts.

Comment 14

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

Changed mac-* back to macosx64-*

Comment 15

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

uploaded the wrong patch.

Comment 16

[Edmund Wong (:ewong)]

Attachment: 1687385-restruct_mozconfigs.patch

needed to fix the mozconfig paths from the mac->macosx64 change

Comment 17

[Frank-Rainer Grahl (:frg)]

Attachment: WIP-1687385-mozconfigs-v3_0-253.patch

Hi I combined both patches into a single one and updated gitlab 2.53. Just need to sort out the author later.
Some comments:
arm currently has the suffix aarch64 in mozilla-land so I changed the directory names.
The objectdir should be version based and not dependent on the topsourcedir. My vision (non drug induced) would be to have no non relative path statements in the configs just dependent subdirectories. Everything elsoe like /e/builds/ should be set via variables. Started with this on the Windows builder but not 100% done there either. See the sample shell skripts which sets a bunch of variables used in the configs. Some like the redist directories were still hardcoded.

Maybe more disucssions via irc or in the next meeting.

Comment 18

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9206232 [details] [diff] [review]
WIP-1687385-mozconfigs-v1_2-253.patch

See previous comment.