1687431 - Send button enabled after removing non-pillified recipient

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Klaus B.]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36

Steps to reproduce:

This seems to have regressed from bug 1679848.

In a new message, enter [e-mail] as recipient without causing a pill to be created. Remove the address again.

Actual results:

Send button stays enabled.

Expected results:

Send button should have been disabled again.

Comment 1

[Alessandro Castellani [:aleca]]

Thanks for the report and for identifying the regression window.
I'll take care of it.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1687431-send-button.diff

We should detect changes also when backspace or delete are pressed.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9198535 [details] [diff] [review]
1687431-send-button.diff

Ship it!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/becd548e1f91
Disable Send button after removing non-pillified addresses. r=darktrojan

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9198535 [details] [diff] [review]
1687431-send-button.diff

[Approval Request Comment]
Regression caused by (bug #): bug 1681389
User impact if declined: The send button is not properly disabled after a user deletes a previously written non-pillified valid account
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low as we're only expanding the check for changing the compose message state on delete or backspace.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9198535 [details] [diff] [review]
1687431-send-button.diff

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/5c23a99004f1

Comment 8

[WaltS48 [:walts48]]

Send button disabled after removing non-pillified recipient using the 78.7.1 release candidate on Windows 10.