1687523 - Empty SessionState when killing App while loading page

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

From https://github.com/mozilla-mobile/fenix/issues/16259#issuecomment-721414841

Looks like sometimes we send an empty SessionState to apps when the app gets killed in the middle of a page load.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

AC implemented this workaround https://github.com/mozilla-mobile/android-components/pull/9446#discussion_r560230841

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1687523 - Do not call onSessionStateChange if session state is null or contains no history. r=#geckoview-reviewers!

Comment 3

[Dylan Roeh (:droeh) (he/him)]

I confirmed we can get "empty" (no history) state from the initial about:blank load, so I'm guessing that's what was happening here. The patch just doesn't call onSessionStateChange unless we actually have history (and therefore a state we can actually restore).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfca58fb6cb1
Do not call onSessionStateChange if session state is null or contains no history. r=geckoview-reviewers,agi

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dfca58fb6cb1