1687586 - [English Grammar Error] - 'Saves to the screenshot directly to the clipboard' - Hovered text when in Firefox devtools

Status: RESOLVED FIXED

(DevTools :: General, defect, P5)

Description

[Not Real]

Attachment: Image of the issue where the incorrect grammar text is shown

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

TLDR: This line has incorrect grammar - https://github.com/mozilla/gecko-dev/blob/7ef5cefd0468b8f509efe38e0212de2398f4c8b3/devtools/client/locales/en-US/toolbox-options.ftl#L69

Steps to reproduce on program:

1. User opens Firefox (currently on Windows 7 Firefox 84.0.2 (64-bit))
2. User opens Developer Tools in Firefox.
3. User clicks the three dots on the top right of Developer Tools. User clicks 'Settings'.
4. User hovers over 'Screenshot to Clipboard' list item under the heading 'Screenshot Behavior'

Actual results:

5. User sees the hovered text as 'Saves to the screenshot directly to the clipboard' which is incorrect English grammar.

Expected results:

User should have seen 'Saves the screenshot directly to the clipboard'. The first 'to' is incorrect.

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[joseph.brozinski]

Can I give this a try? It would be my first contribution. I'm not sure how to access the codebase. Does someone have to send a link?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html has the instructions how to get the source code, create the patch etc.
https://searchfox.org/ let's you search the code.
Please comment if you have questions or get stuck.

Comment 4

[joseph.brozinski]

Thanks! I have the source code and a build running on my machine. I was able to find and correct the line with incorrect grammar. Should I use Phabricator to submit the new code? Who should I send it to for review?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Glad to hear it worked for you so far. Please set r=Honza in the commit message to request review or add him as reviewer in Phabricator after you submitted the patch. He is the triage owner for the Bugzilla component DevTools :: General into which the file with the string belongs (top right).

Comment 6

[joseph.brozinski]

I just commited the patch, I think. I made sure to put r=Honza and the bug number 1687586 in the commit message. If it doesn't show up, or if I did something incorrect, please let me know. I'm not sure I'm using Phabricator correctly, and I want to make sure I follow correct procedure. Thank you.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I don't see your submission. Did moz-phab say the submission succeed and provide a url to the uploaded patch? You likely still need commit access, see https://www.mozilla.org/en-US/about/governance/policies/commit/ how to obtain it. Thank you in advance.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Joseph, I don't see any patch review assigned to me from you.
You might want to take a look at the docs here
https://firefox-source-docs.mozilla.org/mobile/android/geckoview/contributor/contributing-to-mc.html

Honza

Comment 9

[Release mgmt bot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 10

[Garima Mazumdar]

Attachment: Bug 1687586 - [devtools] Fixing title text in the Settings panel. r=Honza

Depends on D111466

Comment 11

[Garima Mazumdar]

Hi, I've just fixed this bug and committed the change using moz-phab, could you please let me know if it has been submitted correctly?

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Garima Mazumdar from comment #11)

Hi, I've just fixed this bug and committed the change using moz-phab, could you please let me know if it has been submitted correctly?

Just commented on the patch, thank you for working on this!

Also, you can use the "Request information from" field at the bottom of this page when asking someone for help. It increases your chances to get an answer since the person will get an notification.

Honza

Comment 13

[Garima Mazumdar]

I've updated the string ID and also updated the reference to it in the code, so while committing, what message should I put?

Comment 14

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Garima Mazumdar from comment #13)

I've updated the string ID and also updated the reference to it in the code, so while committing, what message should I put?

You can use something as follows:

Bug 1687586 - [devtools] Fixing tooltip text in DevTools Settings panel

Comment 15

[Garima Mazumdar]

Attachment: WIP: Bug 1687586 - [devtools] Fixing tooltip text in DevTools Settings panel

Comment 16

[Jan Honza Odvarko [:Honza] (always need-info? me)]

You should update an existing phab patch not create new one with new changes.

Just use:
hg commit --amend

See also:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html?highlight=amend#to-update-a-submitted-patch

Comment 17

[Garima Mazumdar]

Ohh alright, so should I revert the previous commit? And if I should, how should I go about it?

Comment 18

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Go to Phab, click on "Edit Revision" and remove the Bug ID, so the patch disappears from this bug.
You should also "Edit Deatails" of the attachement and mark it as "Obsolete"

Comment 19

[Phabricator Automation]

Comment on attachment 9214866 [details]
WIP: Bug 1687586 - [devtools] Fixing tooltip text in DevTools Settings panel

Revision D111531 was moved to bug 1698595. Setting attachment 9214866 [details] to obsolete.

Comment 20

[Garima Mazumdar]

I'm not sure if it worked, could you please let me know?

Comment 21

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Looks good now.

I assume that the revision that should be updated is this: https://phabricator.services.mozilla.com/D111471

Comment 22

[Garima Mazumdar]

Hi, I've added the changes using moz-phab, please let me know what I should do next

Comment 23

[Garima Mazumdar]

Hey! Just wanted to follow up, could you please let me know what I have to do next? :)

Comment 24

[Jan Honza Odvarko [:Honza] (always need-info? me)]

You need to resolve all the comments made in the attached patch
When uploading changes you should update the existing patch (not create a new one, see also comment #16)
https://phabricator.services.mozilla.com/D111471

Mainly you should:

• Remove unnecessary changes from the patch
• Change the String ID

Honza

Comment 25

[Garima Mazumdar]

Could you tell me how to get rid of the unnecessary changes? Should I get rid of the previous patch and then make the required changes in the necessary files and commit those changes? Or should I add the original lines back to the unnecessary changes and then commit?

Comment 26

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Garima Mazumdar from comment #25)

Or should I add the original lines back and then commit?

Yes and use: hg commit --amend

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/236bbf59a498
[devtools] Fixing title text in the Settings panel. r=Honza,flod

Comment 28

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/236bbf59a498