NS_DECL_ISUPPORTS_INHERITED need only override QueryInterface

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
16 years ago
6 years ago

People

(Reporter: darin.moz, Unassigned)

Tracking

({helpwanted})

Trunk
Future
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

16 years ago
it seems like most consumers of NS_DECL_ISUPPORTS_INHERITED should only override
QueryInterface.  what's the use of reimplementing AddRef and Release as calls to
the Super class's AddRef and Release.  why not just leave out the extra function
calls?

Comment 1

16 years ago
Well, clearly this should be an option.  Maybe the origanal authoer wanted to
allow the inherited class to do special addref/release functionality.  

This is a low hanging fruit to rid ourselves of two extra vtable entries in
layout/content.  

Any takers?

-> future.
Keywords: helpwanted
Target Milestone: --- → Future
Assignee: dougt → nobody
QA Contact: scc → xpcom

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.