Closed Bug 1687605 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27253 - Update cull rect before paint (behind runtime flag)

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27253 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27253
Details from upstream follow.

b'Xianzhu Wang <wangxianzhu@chromium.org>' wrote:

Update cull rect before paint (behind runtime flag)

This is mainly for CompositeAfterPaint to fix the issue of always
repainting on scroll. By updating cull rect before paint, we know which
layer will change cull rect and needs repaint.

This will also simplify interest rect and cull rect calculation and
repaint on their change in pre-CompositeAfterPaint. It will unify
composited layer interest rect calculation and LayoutObject cull rect
calculation, and avoid whole subtree repaint on clip change.

For now the cull rects are used to set PaintLayer's NeedsRepaint flag
only. The next steps are to use the cull rects during painting and to
remove old cull rect calculation code.

Bug: 1046544
Change-Id: I433c7941ebd0a96bc1d75b79a3036511d857629a
Reviewed-on: https://chromium-review.googlesource.com/2629653
WPT-Export-Revision: 5fec9fc2b734a502f8d1c3772977c9c2c497a15c

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d9896e74f3f
[wpt PR 27253] - Update cull rect before paint (behind runtime flag), a=testonly

https://hg.mozilla.org/mozilla-central/rev/4d9896e74f3f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.