Closed Bug 1687668 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27255 - Maintain aspect ratio when object-fit: cover used on a rotated image

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27255 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27255
Details from upstream follow.

b'Stephen Chenney <schenney@chromium.org>' wrote:

Maintain aspect ratio when object-fit: cover used on a rotated image

When a bitmapped image is rotated (due to embedded EXIF orientation
information) the ImagePainter::PaintIntoRect function incorrectly
computed the source rectangle using the unrotated image. This CL
corrects that shortcoming, ensuring that the image's aspect ratio is
maintained.

From a patch by Eric Lawrence now with tests.

Bug: 1082669
Change-Id: I667883481132986cb5a33edd269ab10ac1d29ee7
Reviewed-on: https://chromium-review.googlesource.com/2639804
WPT-Export-Revision: 52c9b760405e8a96f9f710611f85bd400290ada9

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-images/image-orientation/image-orientation-img-object-fit.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b99b554d23c [wpt PR 27255] - Maintain aspect ratio when object-fit: cover used on a rotated image, a=testonly https://hg.mozilla.org/integration/autoland/rev/89cd7abc6ead [wpt PR 27255] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6b99b554d23c
https://hg.mozilla.org/mozilla-central/rev/89cd7abc6ead

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.