1687677 - WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate @ gecko-profiler-interface.js:214

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Florian Quèze [:florian]]

Steps to reproduce:

1. Open about:profiling
2. Open a second tab with about:preferences or about:config

These pages are loaded in the parent process, and trigger a chrome-document-global-created notification, despite being content windows.

I think we should replicate the .isChromeWindow check at https://searchfox.org/mozilla-central/rev/2c06b16a0c15ae340a0532e319cbf89ef9d21b68/toolkit/modules/PrivateBrowsingUtils.jsm#23 in our code. There's no way a content window can be a new private browsing window, so we can ignore these notifications.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1687677 - ignore content windows when checking if a new window is a private window that should lock the profiler, r=julienw.

Comment 2

[Florian Quèze [:florian]]

The full warning in the terminal is:

WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:27:11
_observe@resource://devtools/shared/performance-new/gecko-profiler-interface.js:214:34

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dd53beefb2a
ignore content windows when checking if a new window is a private window that should lock the profiler, r=julienw.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8dd53beefb2a