1687783 - macOS OS-level task scheduler component

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1676296 introduced a TaskScheduler.jsm abstraction around scheduling OS-level tasks, and an implementation for Windows based on Task Scheduler. This ticket tracks adding an implementation for macOS based on launchd.

One thing worth noting here. At this time, there's no macOS installer and/or uninstaller. That means we have no clear point to run code to clean up old scheduled tasks. However, the clever folks at Steam use the WatchPaths launchd.plist key to do some additional clean up when their App is deleted, and we can do similar.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1687783 - Part 1: Enable MOZ_UPDATE_AGENT by default on macOS and Windows. r?#build

At the same time, remove the global define, which isn't necessary and
triggers some rebuilds. Nothing is using MOZ_UPDATE_AGENT right now
so it's safe to enable more broadly, and it will be used to gate new
background update work.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1687783 - Part 2: Expose MOZ_MACBUNDLE_ID in AppConstants.jsm. r?#build

The bundle ID will be used to namespace OS-level tasks registered with
launchd on macOS.

Depends on D102786

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1687783 - Part 3: Make TaskScheduler API explicitly async. r?agashlin!

As written, this will work with the synchronous Windows implementation
and the forthcoming asynchronous macOS implementation. But that's a
recipe for confusion, so let's be explicit and make this API async.

Depends on D102787

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1687783 - Part 4: Implement TaskScheduler on macOS backed by launchd. r?agashlin!,spohl!

Depends on D102788

Comment 5

[Nick Alexander :nalexander [he/him]]

Try build is percolating at https://treeherder.mozilla.org/jobs?repo=try&revision=651de1913989edaebcc9732a5c79d42875c93fdd.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6458260d4e48
Part 1: Enable MOZ_UPDATE_AGENT by default on macOS and Windows. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/545f379b915b
Part 2: Expose MOZ_MACBUNDLE_ID in AppConstants.jsm. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/b9ac8c1fd90f
Part 3: Make TaskScheduler API explicitly async. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/194e31587e6c
Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl

Comment 7

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=194e31587e6c4174702a223b448e8748b1b4a144&selectedTaskRun=QucuBL0pRTKWXXrsEoSiog.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=332643702&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/6b980a8dce8298b9136e982e76a59f631b44b722

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e263e7f465
Part 1: Enable MOZ_UPDATE_AGENT by default on macOS and Windows. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/f4483f7da5bb
Part 2: Expose MOZ_MACBUNDLE_ID in AppConstants.jsm. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/a391f4f760fb
Part 3: Make TaskScheduler API explicitly async. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/4c60dddf4f8c
Part 4: Implement TaskScheduler on macOS backed by launchd. r=agashlin,spohl

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/17e263e7f465
https://hg.mozilla.org/mozilla-central/rev/f4483f7da5bb
https://hg.mozilla.org/mozilla-central/rev/a391f4f760fb
https://hg.mozilla.org/mozilla-central/rev/4c60dddf4f8c

Comment 10

[Nick Alexander :nalexander [he/him]]

Clearing NI since I have relanded this.