1687843 - Process launching should check if pre-allocated process pool is already allocating a process and wait for it

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Chris Peterson [:cpeterson]]

Nika and Jesup say Fission currently launches a new process if the pre-allocated process pool has no ready processes, even if the pool is actively launching a new pre-allocated process. Waiting for the new pre-allocated process will be faster than launching a second process in parallel.

Comment 1

[Chris Peterson [:cpeterson]]

Could be a nice perf benefit but we don't really know. We probably won't run into this situation very often because the pre-allocated process pool should be keep enough processes to avoid this situation.

Tracking for Fission M8 (Release experiment).

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1687843: PreallocatedProcessManager will return a launching process if one exists r=nika

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4f5e8cee582
PreallocatedProcessManager will return a launching process if one exists r=nika

Comment 4

[Marian-Vasile Laza]

Backed out for causing mochitest assertion failures on PreallocatedProcessManager.cpp
Backout link
Push with failures
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ace627c97884
PreallocatedProcessManager will return a launching process if one exists r=nika

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ace627c97884

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0c0b00b2df9
Backed out changeset ace627c97884 for causing Bug 1715414. CLOSED TREE

Comment 8

[Marian-Vasile Laza]

Backed out for causing Bug 1715414.
Backout link

Comment 9

[Alexandru Michis [:malexandru]]

Backout merged to central:
https://hg.mozilla.org/mozilla-central/rev/a0c0b00b2df9920a8e3fc23723058e210079f83c

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49825664d766
PreallocatedProcessManager will return a launching process if one exists r=nika

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/49825664d766