1687891 - Add Telemetry for Principal Validation in ContentParent

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Christoph Kerschbaumer [:ckerschb]]

Within Bug 1687890 we are going to relax the principal validation assertion and within this bug we will add telemetry. In turn that will not users causes to crash. Once we are confident things work correctly again, we can arm the assertion again.

Comment 1

[Tom Ritter [:tjr] (OOTO until 7/21)]

Attachment: Bug 1687891: Add Telemetry for an invalid principal being received from a Fission process r?ckerschb

Comment 2

[Tom Ritter [:tjr] (OOTO until 7/21)]

I tested this manually using Bug 1687104 and ensured that the telemetry event was being created as expected.

Comment 3

[Tom Ritter [:tjr] (OOTO until 7/21)]

Attachment: data-review-contentparent.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9198993 [details]
data-review-contentparent.md

Permanent collections must have an individual responsible for them. Please identify someone for Q7 who will be responsible, and reflag for review.

Comment 5

[Tom Ritter [:tjr] (OOTO until 7/21)]

Attachment: data-review-contentparent.md

Comment 6

[Travis Long [:travis_]]

Comment on attachment 9199513 [details]
data-review-contentparent.md

Taking up the data-review from chutten to help with his review load.

Comment 7

[Travis Long [:travis_]]

Comment on attachment 9199513 [details]
data-review-contentparent.md

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in events.yaml and through the Probe Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Tom Ritter

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2: Interaction Data

5. Is the data collection request for default-on or default-off?

Default on

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does there need to be a check-in in the future to determine whether to renew the data?

No, the collection is permanent/indefinite

9. Does the data collection use a third-party collection tool?

No

Result: data-review+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54a52bb42e78
Add Telemetry for an invalid principal being received from a Fission process r=ckerschb

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/54a52bb42e78