1687959 - Simplify MIR generation in buildSuspend by combining load and unbox

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

In buildSuspend, we do MLoadFixedSlot and then MUnbox

It should be possible to replace this with MLoadFixedSlotAndUnbox

Comment 1

[Jan de Mooij [:jandem]]

If we do this we should make sure we change the BailoutKind in the constructor.

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: build.log

Here is my build log (after doing ./mach clobber). I now see the '-CETCOMPAT' flag is being sent, which explains why CET is being enabled.

I'm not familiar enough with Mozilla's build system to know how to disable CET, though. Any ideas?

Comment 3

[Bryan Thrall [:bthrall]]

(In reply to Bryan Thrall [:bthrall] from comment #2)

Created attachment 9262853 [details]
build.log

Here is my build log (after doing ./mach clobber). I now see the '-CETCOMPAT' flag is being sent, which explains why CET is being enabled.

I'm not familiar enough with Mozilla's build system to know how to disable CET, though. Any ideas?

Oops, wrong bug! Please ignore this message and attachment.

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1687959 - Move setBailoutKind() out of MLoadFixedSlotAndUnbox constructor r?jandem

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1687959 - Replace MLoadFixedSlot and MUnbox with MLoadFixedSlotAndUnbox r?jandem

Depends on D138585

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1687959 - Move setBailoutKind() out of MLoadDynamicSlotAndUnbox, MLoadElementAndUnbox r?jandem

All three load operations are handled consistently now.

Depends on D138586

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71583afe4ed8
Move setBailoutKind() out of MLoadFixedSlotAndUnbox constructor r=jandem
https://hg.mozilla.org/integration/autoland/rev/15bfcf423726
Replace MLoadFixedSlot and MUnbox with MLoadFixedSlotAndUnbox r=jandem
https://hg.mozilla.org/integration/autoland/rev/46383f17a355
Move setBailoutKind() out of MLoadDynamicSlotAndUnbox, MLoadElementAndUnbox r=jandem

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/71583afe4ed8
https://hg.mozilla.org/mozilla-central/rev/15bfcf423726
https://hg.mozilla.org/mozilla-central/rev/46383f17a355