Closed Bug 1687978 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27275 - Prevent underinvalidation of <pattern> with template

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27275 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27275
Details from upstream follow.

b'Fredrik S\xc3\xb6derqvist <fs@opera.com>' wrote:

Prevent underinvalidation of <pattern> with template

If the pattern resource is marked for layout via a mechanism that does
not invalidate its attributes - for example by changing a style property
that only requires paint invalidation - a call to
LayoutSVGResourceContainer::InvalidateCacheAndMarkForLayout() will fail
to properly invalidate attributes, which leaves the pattern in an
inconsistent state.
Drop the early-out check for SelfNeedsLayout() in said method so that
RemoveAllClientsFromCache() is called in the above case as well.

Bug: 1167563
Change-Id: Ib5896da9e52a103b86dc6eb7ad08e30a572b6d22
Reviewed-on: https://chromium-review.googlesource.com/2642777
WPT-Export-Revision: 7c92073dabada8c7431141298e9ff886e2836f6a

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1426ea82ff53 [wpt PR 27275] - Prevent underinvalidation of <pattern> with template, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.