168807 - window.open(url,"_parent") doesn't work correctly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[HARUNAGA Hirotoshi]

window.open(url,"_parent") doesn't work correctly even if parent
frameset exist.

Steps:
1. Go to the URL above.
2. Click window.open("http://www.mozilla.gr.jp/","_parent"); in right
  bottom frame.

Actual result:
A new window opens.

Expected result:
The destination document should be opened in the parent frameset.

http://developer.netscape.com/docs/manuals/communicator/jsref/win1.htm#1152528
windowName
  A string specifying the window name to use in the TARGET attribute
  of a FORM or A tag. windowName can contain only alphanumeric or
  underscore (_) characters.

http://developer.netscape.com/docs/manuals/htmlguid/index.htm?content=tags7.htm#tags:A
  _parent    opens the destination document in the parent window of the
  one displaying the current document.

Note:
If the frame has no parent, "_parent" may act as the value "_self".
http://msdn.microsoft.com/library/default.asp?url=/workshop/author/dhtml/reference/methods/open_0.asp

Related to Bug 87968.

Comment 1

[HARUNAGA Hirotoshi]

This seems to be a regression of Bug 70331.

Comment 2

[Amarendra Hanumanula]

forwarding this to DOM Level 0 component.

Comment 3

[HARUNAGA Hirotoshi]

Reassigning to default owner.

Comment 4

[Harshal Pradhan]

Attachment: fix up stuff in nsWindowWatcher.cpp to make this work as expected

Comment 5

[Harshal Pradhan]

cc'ing [e-mail] who seems to know about this code (going by cvsblame)

Comment 6

[Dan M]

Comment on attachment 104359 [details] [diff] [review]
fix up stuff in nsWindowWatcher.cpp to make this work as expected

What, has this never worked? I distinctly recall a time when _parent worked. I
can verify that it's busted. I agree this patch is good and the right
short-term fix. In the long run, we should ditch all the special-case code in
nsWindowWatcher and call a version of nsDocShell::FindTarget that won't create
a new window itself. See bug 103638.

Comment 7

[Harshal Pradhan]

Taking bug. (since danm seems to be happy with getting my patch in till such a
time as the big cleanup happens.)

danm, I'm new, help me out a bit more here ...
What next? Who do I ask for sr for windowwatcher stuff ? (BTW, what bugzilla
component is windowwatcher supposed to be anyways?)

Comment 8

[John Keiser (jkeiser)]

This patch looks good to me; good to be reminded of the target cleanup though :)

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 104359 [details] [diff] [review]
fix up stuff in nsWindowWatcher.cpp to make this work as expected

sr=jst

Comment 10

[Dan M]

Patch is in. Thanks Harshal!