1688071 - tb windows perma fail: comm/mailnews/base/test/unit/test_folderLookupService.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=327358283&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XXsUVyzkQA2vczWttAKLGg/runs/0/artifacts/public/logs/live_backing.log

---

Must be a regression from bug 1687412 as it just started showing up```

Comment 1

[Magnus Melin [:mkmelin]]

[task 2021-01-21T12:03:27.950Z] 12:03:27 INFO - comm/mailnews/base/test/unit/test_folderLookupService.js | Starting test_unicode_uris
[task 2021-01-21T12:03:27.950Z] 12:03:27 INFO - (xpcshell/head.js) | test test_unicode_uris pending (2)
[task 2021-01-21T12:03:27.950Z] 12:03:27 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - Unexpected exception TypeError: can't access property "URI", tap is null at Z:/task_1611229883/build/tests/xpcshell/tests/comm/mailnews/base/test/unit/test_folderLookupService.js:75
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - test_unicode_uris@Z:/task_1611229883/build/tests/xpcshell/tests/comm/mailnews/base/test/unit/test_folderLookupService.js:75:3
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - _run_next_test/<@Z:\task_1611229883\build\tests\xpcshell\head.js:1620:22
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - _run_next_test@Z:\task_1611229883\build\tests\xpcshell\head.js:1620:38
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - run@Z:\task_1611229883\build\tests\xpcshell\head.js:767:9
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - _do_main@Z:\task_1611229883\build\tests\xpcshell\head.js:239:6
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - _execute_test@Z:\task_1611229883\build\tests\xpcshell\head.js:567:5
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - @-e:1:1
[task 2021-01-21T12:03:27.951Z] 12:03:27 INFO - exiting test

https://searchfox.org/comm-central/rev/477376239c7add0cb7581d788e2cd79a1a4360b2/mailnews/base/test/unit/test_folderLookupService.js#75

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: 1688071.patch

The failing test case was newly added in bug 1687412. Found that non-ASCII folder name is hashed on Windows, so treat it different in the test.

Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=bfb386fc78a2e60373789c783b5c2dfbd11fb15e

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9198579 [details] [diff] [review]
1688071.patch

Review of attachment 9198579 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! 
As I recall it's not "non-ascii" that is hashed, but names that can't be used since they have characters that the windows file system can't support. 
It's a bit (or a few!) odd that this hashing is also inside the url of course...

Comment 4

[Ping Chen [:rnons] (away)]

Perhaps "non-ascii" is inaccurate, it's hashed when ConvertibleToNative https://searchfox.org/comm-central/source/mailnews/base/src/nsMsgUtils.cpp#296 returns false.

Comment 5

[Klaus B.]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af9af6bc9337c93c6ca214dbd4eb24a05f01ac24
Fix test_folderLookupService.js for Windows. r=mkmelin

Comment 6

[Intermittent Failures Robot]

19 failures in 3488 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 19

Platform and build breakdown:

• windows10-64-shippable: 4
  • opt: 4
• windows10-64: 6
  • debug: 3
  • opt: 3
• windows7-32: 6
  • debug: 3
  • opt: 3
• windows7-32-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1688071&startday=2021-01-18&endday=2021-01-24&tree=all