1688213 - Control "signon.management.page.fileImport.enabled" via Nimbus

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P3)

Description

[Tim Giles [:tgiles]]

After landing and verifying all of the work surrounding Login CSV import in Nightly, we need to enable login CSV import for all channels.

Comment 1

[Andrei Petcu]

Can I pick this up?

Comment 3

[Tim Giles [:tgiles]]

:petcuandrei, this is blocked until 1689119 and 1688653 are resolved.

Comment 4

[Andrei Petcu]

Attachment: Bug 1688213 Enable "signon.management.page.fileImport.enabled" for all channels

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/002302cfc97d
Enable "signon.management.page.fileImport.enabled" for all channels r=sfoster

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/002302cfc97d

Comment 7

[Mathew Hodson]

Should this bug be reopened since it was backed out by bug 1702336?

Comment 8

[Tim Giles [:tgiles]]

For tracking purposes, yeah we can reopen this. We will need to clear the blocking bugs on Bug 1705529 before we can re-enable login CSV import.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Hey Neil,

Thanks for all of your work fixing the sync issue! With the syncing issue fixed, do you know if we're okay to land this pref flip to ride the trains?

Comment 10

[Neil Deakin]

QA is planning on testing this feature very soon. I think we could enable the preference in Nightly at least.

Comment 11

[Neil Deakin]

Attachment: WIP: Bug 1688213, enable csv login import on nightly

Comment 12

[Sergey Galich [:serg]]

Attachment: Bug 1688213 - allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Comment 13

[Sergey Galich [:serg]]

Slight change of plan, lets use Nimbus to enable this pref and do a rollout.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4feb54cd43c
allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e4feb54cd43c

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9342295 [details]
Bug 1688213 - allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Beta/Release Uplift Approval Request

• User impact if declined: Users will not be able to be enrolled in experiments or rollouts that enable CSV password import.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small, well understood change that adds a pref flip to the Nimbus feature manifest file to allow for remote control of that pref.
• String changes made/needed: None.
• Is Android affected?: No

Comment 17

[Dianna Smith [:diannaS]]

Comment on attachment 9342295 [details]
Bug 1688213 - allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Approved for 116.0b2

Comment 18

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/59fadae187c4