Closed Bug 1688213 Opened 4 years ago Closed 1 year ago

Control "signon.management.page.fileImport.enabled" via Nimbus

Categories

(Firefox :: about:logins, task, P3)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- wontfix
firefox116 --- fixed
firefox117 --- fixed

People

(Reporter: tgiles, Assigned: serg)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxcm-csv-import])

Attachments

(2 files, 1 obsolete file)

After landing and verifying all of the work surrounding Login CSV import in Nightly, we need to enable login CSV import for all channels.

See Also: → 1650675, 1649940, 1641777
Priority: -- → P3
Severity: -- → N/A
Depends on: 1688653
Depends on: 1689119

Can I pick this up?

Blocks: 1303176

:petcuandrei, this is blocked until 1689119 and 1688653 are resolved.

Depends on: 1688051
See Also: → 1692481
Assignee: nobody → petcuandrei
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/002302cfc97d
Enable "signon.management.page.fileImport.enabled" for all channels r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Should this bug be reopened since it was backed out by bug 1702336?

Flags: needinfo?(tgiles)
Depends on: 1705529

For tracking purposes, yeah we can reopen this. We will need to clear the blocking bugs on Bug 1705529 before we can re-enable login CSV import.

Assignee: petcuandrei → nobody
Status: RESOLVED → REOPENED
Flags: needinfo?(tgiles)
Resolution: FIXED → ---
Whiteboard: [fxcm-csv-import]

Hey Neil,

Thanks for all of your work fixing the sync issue! With the syncing issue fixed, do you know if we're okay to land this pref flip to ride the trains?

Flags: needinfo?(enndeakin)

QA is planning on testing this feature very soon. I think we could enable the preference in Nightly at least.

Flags: needinfo?(enndeakin)
Assignee: nobody → sgalich

Slight change of plan, lets use Nimbus to enable this pref and do a rollout.

Summary: Enable "signon.management.page.fileImport.enabled" for all channels → Control "signon.management.page.fileImport.enabled" via Nimbus
Pushed by sgalich@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4feb54cd43c
allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley
Status: REOPENED → RESOLVED
Closed: 3 years ago1 year ago
Resolution: --- → FIXED

Comment on attachment 9342295 [details]
Bug 1688213 - allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Users will not be able to be enrolled in experiments or rollouts that enable CSV password import.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a small, well understood change that adds a pref flip to the Nimbus feature manifest file to allow for remote control of that pref.
  • String changes made/needed: None.
  • Is Android affected?: No
Attachment #9342295 - Flags: approval-mozilla-beta?

Comment on attachment 9342295 [details]
Bug 1688213 - allowing Nimbus to control signon.management.page.fileImport.enabled pref r=mconley

Approved for 116.0b2

Attachment #9342295 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
See Also: → 1843446
Regressions: 1844684
Attachment #9339314 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: