1688221 - Perma toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js | localStorage for https://example.org has expected value testKey=thirdParty - when Gecko 86 switches to Late Beta on 2021-02-05

Status: VERIFIED FIXED

(Core :: Storage: StorageManager, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-late-beta simulation
Failure log

[task 2021-01-22T13:24:01.260Z] 13:24:01 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js | localStorage for https://example.com has expected value testKey=firstParty -
[task 2021-01-22T13:24:01.261Z] 13:24:01 INFO - Testing: Unpartitioned localStorage has not changed
[task 2021-01-22T13:24:01.262Z] 13:24:01 INFO - Buffered messages finished
[task 2021-01-22T13:24:01.265Z] 13:24:01 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js | localStorage for https://example.org has expected value testKey=thirdParty -
[task 2021-01-22T13:24:01.265Z] 13:24:01 INFO - Stack trace:
[task 2021-01-22T13:24:01.266Z] 13:24:01 INFO - chrome://mochikit/content/browser-test.js:test_ok:1323
[task 2021-01-22T13:24:01.266Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:testHasLocalStorageEntry:281
[task 2021-01-22T13:24:01.266Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:localStorageClearThirdParty/<:516
[task 2021-01-22T13:24:01.266Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:runClearSiteDataTest:169
[task 2021-01-22T13:24:01.271Z] 13:24:01 INFO - Testing: Partitioned localStorage for HOST_B (HOST_A) has been cleared
...
[task 2021-01-22T13:24:01.670Z] 13:24:01 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js | localStorage for https://example.org (partitioned under https://example.com) has expected value testKey=thirdPartyPartitioned -
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - Testing: Partitioned localStorage for HOST_A (HOST_B) has not changed
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js | localStorage for https://example.com (partitioned under https://example.org) has expected value testKey=thirdPartyPartitioned2 -
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - Stack trace:
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - chrome://mochikit/content/browser-test.js:test_ok:1323
[task 2021-01-22T13:24:01.671Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:testHasLocalStorageEntry:281
[task 2021-01-22T13:24:01.672Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:localStorageClearFirstParty/<:564
[task 2021-01-22T13:24:01.672Z] 13:24:01 INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/browser_partitionedClearSiteDataHeader.js:runClearSiteDataTest:169
[task 2021-01-22T13:24:01.674Z] 13:24:01 INFO - Cleaning up.
[task 2021-01-22T13:24:01.755Z] 13:24:01 INFO - Leaving test bound localStorageClearFirstParty

Late Beta doesn't use the next generation storage.

Comment 1

[Paul Zühlcke [:pbz]]

I believe this fails because the legacy storage implementation that we ship to release only clears by host (instead of full origin). I've filed Bug 1688665. To unblock this for now I suggest we set dom.storage.next_gen=true for the test.
Currently testing to verify this fixes the test failure.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1688221 - Always enable next-gen storage for clearSiteDataHeader test. r=johannh!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1688221 - Skip localStorage clear-site-data tests for legacy localStorage implementation. r=johannh!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99392b9e0290
Skip localStorage clear-site-data tests for legacy localStorage implementation. r=johannh

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/99392b9e0290

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-late-beta simulation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pbz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Paul Zühlcke [:pbz]]

Comment on attachment 9199253 [details]
Bug 1688221 - Skip localStorage clear-site-data tests for legacy localStorage implementation. r=johannh!

Beta/Release Uplift Approval Request

• User impact if declined: No direct user impact, test failure.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test change only
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9199253 [details]
Bug 1688221 - Skip localStorage clear-site-data tests for legacy localStorage implementation. r=johannh!

Approved for 86 beta 5, thanks.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/292dc867d5a6