1688229 - Folder Properties dialog always updates the database

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[e-mail]]

Bug 473458 failed to convert one instance of getDatabase() to msgDatabase...

Comment 1

[[e-mail]]

Attachment: Proposed patch

Since the old property no longer exists, the call always throws, forcing the database to update from the server every time.

Comment 2

[Ben Bucksch (:BenB)]

Funny, a 12 year old bug and regression that nobody noticed :) . Thanks for finding and fixing it.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9198682 [details] [diff] [review]
Proposed patch

Oh dear. :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1517626fcea2
Fix last reference to getDatabase after bug 473458. r=darktrojan

Comment 5

[[e-mail]]

Comment on attachment 9198682 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 473458
User impact if declined: Extra server traffic when opening folder properties dialog
Risk to taking this patch (and alternatives if risky): Low, fixing unwanted exception

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9198682 [details] [diff] [review]
Proposed patch

[Triage Comment]
Approved for beta

Thanks for the fix. Hopefully 13 is not unlucky.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ce5929ced63e

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9198682 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): bug 473458
User impact if declined: slight perf degradation
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): very safe

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9198682 [details] [diff] [review]
Proposed patch

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/91809c596ba8