1688272 - Search bar scroll updates.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Erica Wright [:ewright]]

When scrolling, the height of the search bar should be a bit larger
when scrolling down the search bar jumps slightly.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1688272 - Fix searchbar sizing and scroll effects.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59523a85025d
Fix searchbar sizing and scroll effects. r=prathiksha

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81fab2decf8f
Add missing space-before-brace on _Search.scss a=lint-fix

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/59523a85025d
https://hg.mozilla.org/mozilla-central/rev/81fab2decf8f

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the Search bar retains its dimensions when scrolling down the New Tab page on both the old experience as well as the new one on the latest Firefox Nightly 87.0a1 (BuildID 20210127093943) using Windows 10, macOS 10.15, and LinuxMX 4.19.

Comment 6

[Erica Wright [:ewright]]

Comment on attachment 9198765 [details]
Bug 1688272 - Fix searchbar sizing and scroll effects.

Beta/Release Uplift Approval Request

• User impact if declined: We intend to do some experiments in 86 with the new tab experience, because of some height adjustments the search bar and page content will jump when the user scrolls down. Users i those experiments will have a poor experience.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk CSS only patch, hidden behind a pref

Other uplifts: perhaps this linting patch referenceed in comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1688272#c3

• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9198765 [details]
Bug 1688272 - Fix searchbar sizing and scroll effects.

Approved for 86 beta 4, thanks.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/490839870746
https://hg.mozilla.org/releases/mozilla-beta/rev/79c1c7d57ce9

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the Search bar retains its dimensions when scrolling down the New Tab page on both the old experience as well as the new one on the latest Firefox Beta 86.0b4 (BuildID 20210131185630) using Windows 10, macOS 10.15, and Linux Mint 20.