1688325 - The new non-native widget theme doesn't have any padding between blinking cursor & border, in a textarea

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Daniel Holbert [:dholbert]]

+++ This bug was initially created as a clone of Bug #1686606 +++

STR:

1. Run Firefox with about:config widget.disable-native-theme-for-content set to true.
2. View https://bugzilla.mozilla.org/attachment.cgi?id=9196980
3. Focus the textarea (the lower/taller form control)

ACTUAL RESULTS:
In the textarea, the blinking cursor is flush with (or maybe even overlaps?) the top border. This makes it look a bit misaligned / overflowing.

For comparison: in the textfield (the first widget), there's a little bit of space between the cursor and the borders, as of today's Nightly (thanks to bug 1686606).

EXPECTED RESULTS:
There should be a little bit of blank padding-area between the blinking cursor and the textarea's border, to visually separate them.

Comment 1

[Daniel Holbert [:dholbert]]

ni=emilio in case he's up for taking a look, since he just landed a fix for related bug 1686606.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

We don't have any padding on textareas by default. I see the same behavior on other themes. We could certainly add some (Chrome seems to have 2px padding by default). But this doesn't seem like a non-native theme specific thing, unless I'm missing something?

Comment 3

[Daniel Holbert [:dholbert]]

Hmm -- on Ubuntu and MacOS, I do indeed see that there's no padding by default.

However, on Windows (where most of our users are), there does seem to be 2px of padding, in the default theme on Firefox release. (screenshot coming up). So we probably don't want to regress that; and given that it seems webcompat-friendly (per Chrome's behavior), maybe we should adopt it as our cross-platform standard behavior in the new non-native theme?

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot of rough expected rendering, using textarea on Win10 with Firefox release (v84)

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screenshot of computed 'padding' properties on Win10 with current Firefox release (for reference)

Here's the default computed 'padding' styles of a textarea, in current Firefox on Win10 -- as you can see, it's 2px on all sides.

(On Ubuntu [not shown here], I do see that we have 0px padding on the top and bottom, by default. But on Win10, we seem to use 2px on all sides.)

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1688325 - Make textarea default padding 2px on all platforms. r=dholbert

This matches other browsers, and the default themed textareas on Windows
too.

To be landed after the soft freeze, just in case, of course.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64682b454ac6
Make textarea default padding 2px on all platforms. r=dholbert

Comment 8

[Atila Butkovits]

Backed out for causing failures on browser_inplace-editor_maxwidth.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/31462a8e07406103e8d97b19faf9af3bd63530b6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=E9eyDlOnQi6c4aq97GSfGw.0&revision=64682b454ac62a9ad7bccedd3efce40e1dab29ae&searchStr=dt

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327674911&repo=autoland&lineNumber=4367

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2cef92ec339
Make textarea default padding 2px on all platforms. r=dholbert,jdescottes

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f2cef92ec339