Closed Bug 1688387 Opened 3 years ago Closed 3 years ago

Permafailing tier 2 UntrustedModulesFixture.Serialize | Expected equality of these values:

Categories

(Firefox :: Launcher Process, defect, P5)

Product:
Firefox
Component:
Launcher Process
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: toshi)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1688387 - UntrustedModulesFixture expects to load modules listed on the blocklist. r=mhowell
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=327575994&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R8LAuqE_Sbak9qLuMC1p7Q/runs/0/artifacts/public/logs/live_backing.log

[task 2021-01-23T12:28:27.346Z] 12:28:27     INFO -  TEST-START | UntrustedModulesFixture.Serialize
[task 2021-01-23T12:28:29.896Z] 12:28:29     INFO -  Received data. (pendingQueries=18)
[task 2021-01-23T12:28:29.942Z] 12:28:29     INFO -  Received data. (pendingQueries=18)
[task 2021-01-23T12:28:29.943Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.943Z] 12:28:29     INFO -    evt.mLoadStatus
[task 2021-01-23T12:28:29.943Z] 12:28:29     INFO -      Which is: 1
[task 2021-01-23T12:28:29.945Z] 12:28:29     INFO -    0 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:152
[task 2021-01-23T12:28:29.945Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.945Z] 12:28:29     INFO -    evt.mLoadStatus
[task 2021-01-23T12:28:29.946Z] 12:28:29     INFO -      Which is: 1
[task 2021-01-23T12:28:29.946Z] 12:28:29     INFO -    0 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:152
[task 2021-01-23T12:28:29.947Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.947Z] 12:28:29     INFO -    evt.mLoadStatus
[task 2021-01-23T12:28:29.947Z] 12:28:29     INFO -      Which is: 2
[task 2021-01-23T12:28:29.947Z] 12:28:29     INFO -    0 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:152
[task 2021-01-23T12:28:29.948Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.948Z] 12:28:29     INFO -    evt.mThreadId
[task 2021-01-23T12:28:29.948Z] 12:28:29     INFO -      Which is: 4848
[task 2021-01-23T12:28:29.948Z] 12:28:29     INFO -    ::GetCurrentThreadId()
[task 2021-01-23T12:28:29.949Z] 12:28:29     INFO -      Which is: 3928 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:148
[task 2021-01-23T12:28:29.949Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.950Z] 12:28:29     INFO -    evt.mLoadStatus
[task 2021-01-23T12:28:29.950Z] 12:28:29     INFO -      Which is: 1
[task 2021-01-23T12:28:29.950Z] 12:28:29     INFO -    0 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:152
[task 2021-01-23T12:28:29.951Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.951Z] 12:28:29     INFO -    evt.mThreadId
[task 2021-01-23T12:28:29.951Z] 12:28:29     INFO -      Which is: 8792
[task 2021-01-23T12:28:29.951Z] 12:28:29     INFO -    ::GetCurrentThreadId()
[task 2021-01-23T12:28:29.952Z] 12:28:29     INFO -      Which is: 3928 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:148
[task 2021-01-23T12:28:29.952Z] 12:28:29  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | Expected equality of these values:
[task 2021-01-23T12:28:29.952Z] 12:28:29     INFO -    evt.mLoadStatus
[task 2021-01-23T12:28:29.952Z] 12:28:29     INFO -      Which is: 1
[task 2021-01-23T12:28:29.953Z] 12:28:29     INFO -    0 @ z:/build/build/src/toolkit/xre/test/gtest/TestUntrustedModules.cpp:152
[task 2021-01-23T12:28:30.002Z] 12:28:30     INFO -  Received data. (pendingQueries=8)
[task 2021-01-23T12:28:30.031Z] 12:28:30     INFO -  Received data. (pendingQueries=9)
[task 2021-01-23T12:28:30.061Z] 12:28:30     INFO -  Received data. (pendingQueries=9)
[task 2021-01-23T12:28:30.065Z] 12:28:30  WARNING -  TEST-UNEXPECTED-FAIL | UntrustedModulesFixture.Serialize | test completed (time: 2718ms)```

This seems to have been caused by Bug 1686229.
Toshi, any chance you could take a look at this?
Thank you.

Flags: needinfo?(tkikuchi)
Component: GTest → Launcher Process
Product: Testing → Firefox

In GTest of the CCov build, UntrustedModulesFixture test detected the following
modules which were loaded by the TestDllBlocklist.* tests in the same process.

  • TestDllBlocklist_MatchByName.dll
  • TestDllBlocklist_MatchByVersion.dll
  • TestDllBlocklist_NoOpEntryPoint.dll

Since they are loaded in a different thread from the one running
UntrustedModulesFixture and are blocked/redirected by our blocklist,
UntrustedModulesFixture needs to verify its loading result differently.
This patch defines an array of the expected results of these modules.

Assignee: nobody → tkikuchi
Status: NEW → ASSIGNED
Flags: needinfo?(tkikuchi)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13051ca09fb5
UntrustedModulesFixture expects to load modules listed on the blocklist.  r=mhowell

https://hg.mozilla.org/mozilla-central/rev/13051ca09fb5

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

Set release status flags based on info from the regressing bug 1686229

status-firefox85: --- → unaffected
status-firefox86: --- → affected
status-firefox-esr78: --- → unaffected

The patch landed in nightly and beta is affected.
:toshi, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(tkikuchi)

Since this is a test bug, no uplift is needed. Setting wontfix on v86.

status-firefox86: affected → wontfix
Flags: needinfo?(tkikuchi)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: