1688420 - 'Other' data not saved in user account vCard

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Codain]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

1. Open Account manager
2. Select an account
3. Edit vCard
4. Go into Other tab (third tab)
5. Put "test" in all five fields
6. Save
7. Reopen vCard and go into Other tab
8. See that only one over 5 fields has been saved

Actual results:

Only one over 5 Other fields has been saved

Expected results:

All 5 Other fields saved

Comment 1

[Wayne Mery (:wsmwk)]

TCW do you see this?

Comment 2

[Arthur K. (he/him)]

Yup, I can confirm this one. Only the Notes field kept the word "test" and all others are blank. Tested with 78.6.0.

Comment 3

[Wayne Mery (:wsmwk)]

Anything in error console?
Did this work in version 68?

Comment 4

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #3)

Anything in error console?
Did this work in version 68?

Nothing in error console and I don't have 68 handy to test with. I've never used vCards.

Comment 5

[Magnus Melin [:mkmelin]]

Confirmed on trunk.
https://searchfox.org/comm-central/rev/b3bfd884582cf43d95cfdd5b635cefacad1511f1/mail/components/addrbook/content/abCard.js#470 -> https://searchfox.org/comm-central/rev/b3bfd884582cf43d95cfdd5b635cefacad1511f1/mail/components/addrbook/content/abCard.js#629

On 68, edit vCard from the account settings doesn't list the custom1-4 fields, only Notes. (So there's nothing to save!)
That could be the bug...

Comment 6

[Magnus Melin [:mkmelin]]

In vCard those custom1-custom4 fields do not exist - that's why they are not saved/mapped and thus disappear. We just store the encoded vcard value as string for the identity in question.

xref bug 30684.

Comment 7

[Codain]

Understood, I see two options:

1. Warn user at export of the fields which will not be exported (I don't like popup but since there is no export window or wizard a popup is better than nothing)
2. Create TB specific custom vCards ids for those fields + warn at exports that [list of fields] are TB specifics and might not be supported by other softwares

I prefer second option.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: Bug 1688420 - identity vCard editing should not show custom fields that don't map to a vCard. r=freaktechnik

• The custom fields can't really be mapped to a vCard representation, so should not be shown for your own card.
• For the main view (am-main) the edited vCard wasn't getting saved at all times... since account manager in a tab
• wrap="virtual" isn't a thing
• flex= doesn't work on html
• textarea is not self closing

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2523efa93844
identity vCard editing should not show custom fields that don't map to a vCard. r=freaktechnik