Closed Bug 1688438 Opened 3 years ago Closed 2 years ago

Replace ws in WebRender debugger with another websocket implementation

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: xidorn, Unassigned)

References

Details

(Keywords: good-first-bug)

ws package is mostly unmaintained, and contains an open vulnerability. While it's probably not a big concern for WebRender as it's only used in debugger, it is still better to replace it with something else.

Severity: -- → N/A
Keywords: good-first-bug

Can i work on this? I could replace it with any other popular implementation after discussion

Flags: needinfo?(xidorn+moz)
Flags: needinfo?(jmathies)

I'll leave the decision to Jim.

It seems the easiest thing to do is probably to replace with the parity fork parity-ws. Alternative, we can switch to the more popular tungstenite, but it's unclear how much effort it would take.

Flags: needinfo?(xidorn+moz)

Okay i will wait.

Blocks: gfx-triage
Flags: needinfo?(jmathies)

The parity fork seems fine.

No longer blocks: gfx-triage

ws is no longer used in WR.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.