1688474 - `browser` is undefined in Add-on Preferences tab with e10s enabled

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Mark Banner (:standard8)]

On the latest Thunderbird build, with e10s enabled, if I try to open a preferences tab which is a WebExtension page, then browser is undefined.

If I load a different WebExtension page in a tab via browser.tabs.create, then the browser object is defined.

Comment 1

[Geoff Lankow (:darktrojan)]

That's weird. I'm sure it worked, and also we have a test that should have failed but didn't. And yet, it doesn't work. I have a fix.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1688474 - Fix creation of moz-extension page tabs. r?mkmelin

It looks like changing the remoteness of a <browser> element in this way breaks something that the "extension-browser-inserted" event sets up. Firing it again seems to work.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0001e7c85da6
Fix creation of moz-extension page tabs. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9199105 [details]
Bug 1688474 - Fix creation of moz-extension page tabs. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): tb-fission
User impact if declined: extension pages in tabs are broken
Testing completed (on c-c, etc.): landed ~12h ago
Risk to taking this patch (and alternatives if risky): a small chance I've not thought of some side effect, but worth it

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9199105 [details]
Bug 1688474 - Fix creation of moz-extension page tabs. r?mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 86.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/2030a27455ae