1688476 - Port bug 1679688 to Thunderbird - make host permissions grant access to privileged parts of the tabs API

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task, P1)

Description

[Magnus Melin [:mkmelin]]

Pretty sure this is what's causing all the orange WX tests.

https://hg.mozilla.org/mozilla-central/rev/a5b3fa068d5e

Comment 1

[Intermittent Failures Robot]

22 failures in 3488 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 22

Platform and build breakdown:

• linux64: 3
  • debug: 2
  • opt: 1
• windows10-64: 4
  • opt: 2
  • debug: 2
• windows7-32: 4
  • opt: 2
  • debug: 2
• linux64-shippable: 2
  • opt: 2
• macosx1014-64: 3
  • opt: 2
  • debug: 1
• macosx1014-64-shippable: 2
  • opt: 2
• windows10-64-shippable: 2
  • opt: 2
• windows7-32-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1688476&startday=2021-01-18&endday=2021-01-24&tree=all

Comment 2

[John Bieling (:TbSync)]

Multiple things happen here.

1. This change in ext-tabs-base.js is causing our mailTabs.query() function to return empty, causing almost all of our tests to fail.
   https://hg.mozilla.org/mozilla-central/diff/a5b3fa068d5ee122dac27298d7da7d7231d3db49/toolkit/components/extensions/parent/ext-tabs-base.js#l1.67

We need to add title: null to here:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mailTabs.js#169

2. The new get matchesHostPermission() function fails when checking our editor#content-frame tabs and our address book.
   https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#203

When debugging and checking the value for this.browser.currentURI.spec I get about:blank?compose, checking this._url returns undefined, which I do not understand, as it is defined a few lines below as:
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-tabs-base.js#221-223

Replacing this._url by this.browser.currentURI.spec fixes these errors for the editor tabs, but not for the address book, as this.browser is not defined. To fix this I just return false in my debug patch, if the function fails for any reason.

Comment 3

[John Bieling (:TbSync)]

Attachment: bug1688476_fix_mailTabs.query.patch

This fixes the failing mailTabs.query

Comment 4

[John Bieling (:TbSync)]

Attachment: bug1688476_debug_m_c_fix_for_matchesHostPermission.patch

This is my debug patch for M-C to get our tests working again.

To fix that in C-C we need to make sure all our tabs have a browser with a currentURI defined. This is currently not the case for our address book (and maybe more).

Furthermore, we must ensure, that calls to this._url properly returns the URL. This currently fails mysteriously for editor#content-frame, even though this.browser.currentURI.spec (which is this._url) returns something useful (about:blank?compose).

Comment 5

[John Bieling (:TbSync)]

Should we file a patch at m-c which failsafes matchesHostPermission() and maybe all calls which use this.browser, or should we fix that in c-c?

Comment 6

[alta88]

To fix that in C-C we need to make sure all our tabs have a browser with a currentURI defined. This is currently not the case for our address book (and maybe more).

This problem has been mentioned numerous times without resolution. For example, see Bug 1649035 and Bug 1680587.

Comment 7

[John Bieling (:TbSync)]

Attachment: bug1688476_fix_mailTabs.query_and_TabmailTab.TabmailTab.matchesHostPermission.patch

Thanks for the tip, Geoff!

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9199112 [details] [diff] [review]
bug1688476_fix_mailTabs.query_and_TabmailTab.TabmailTab.matchesHostPermission.patch

The comment should have a . and one fewer * at the end, but I'll do it when I land this shortly.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0115f45d6db7
Fix mailTabs.query() and Tab.matchesHostPermission(). r=darktrojan

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9199112 [details] [diff] [review]
bug1688476_fix_mailTabs.query_and_TabmailTab.TabmailTab.matchesHostPermission.patch

[Approval Request Comment]
Per Geoff, this will fix errors seen on early builds of what will be 86.0b1.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9199112 [details] [diff] [review]
bug1688476_fix_mailTabs.query_and_TabmailTab.TabmailTab.matchesHostPermission.patch

[Triage Comment]
definitely approved for beta :)

Comment 12

[Intermittent Failures Robot]

23 failures in 657 pushes (0.035 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform and build breakdown:

• macosx1014-64: 4
  • debug: 2
  • opt: 2
• linux64: 4
  • debug: 2
  • opt: 2
• windows7-32: 3
  • opt: 2
  • debug: 1
• windows10-64: 4
  • debug: 2
  • opt: 2
• macosx1014-64-shippable: 2
  • opt: 2
• windows7-32-shippable: 2
  • opt: 2
• linux64-shippable: 2
  • opt: 2
• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1688476&startday=2021-01-25&endday=2021-01-25&tree=all

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 86.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/c1ff200c400aff6de315db81a6beba281e1c97ab

Comment 14

[Intermittent Failures Robot]

23 failures in 3891 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 23

Platform and build breakdown:

• macosx1014-64: 4
  • debug: 2
  • opt: 2
• linux64: 4
  • debug: 2
  • opt: 2
• windows7-32: 3
  • opt: 2
  • debug: 1
• windows10-64: 4
  • debug: 2
  • opt: 2
• macosx1014-64-shippable: 2
  • opt: 2
• windows7-32-shippable: 2
  • opt: 2
• linux64-shippable: 2
  • opt: 2
• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1688476&startday=2021-01-25&endday=2021-01-31&tree=all