1688502 - nsBidiPresUtils.cpp: do not use 'else' after 'break'

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/layout/base/nsBidiPresUtils.cpp#1338

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[TANWEER ALI]

Hey I want to work on this bug.

Thanks
Tanweer

Comment 2

[TANWEER ALI]

I did not see the last line. Sure I have started working on this bug. I will create a patch soon.

Comment 3

[TANWEER ALI]

Attachment: Bug 1688502 - [Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=Sylvestre

Comment 4

[TANWEER ALI]

Attachment: Bug 1688502 - [Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=Sylvestre

Comment 5

[TANWEER ALI]

Attachment: Bug 1688502 - Remove else if condition after break in layout/base/nsBidiPresUtils.cpp r=Sylvestre

Comment 6

[TANWEER ALI]

Attachment: Bug 1688502 - [Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=Sylvestre

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Please stop creating new reviews. Update the existing reviews.
See
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-update-a-submitted-patch

Comment 8

[TANWEER ALI]

Yeah got it. moz-phab is submitting revision to recent one. I want to submit this to the revision before recent one. As by mistake I created new revision https://phabricator.services.mozilla.com/D103701 but the revision which I want to update is https://phabricator.services.mozilla.com/D103596. How to tackle this situation.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

please read the documentation.
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

this is explained

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a83c0d2c34e0
[Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=sylvestre

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a83c0d2c34e0