Closed Bug 1688502 Opened 3 months ago Closed 2 months ago

nsBidiPresUtils.cpp: do not use 'else' after 'break'

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: Sylvestre, Assigned: tanweerali908)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 3 obsolete files)

Filling as a good first bug to learn workflows.

do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/layout/base/nsBidiPresUtils.cpp#1338

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Hey I want to work on this bug.

Thanks
Tanweer

I did not see the last line. Sure I have started working on this bug. I will create a patch soon.

Assignee: nobody → tanweerali908
Status: NEW → ASSIGNED
Attachment #9200141 - Attachment is obsolete: true
Attachment #9200168 - Attachment is obsolete: true
Attachment #9200312 - Attachment description: Bug 1688502 - [Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=Sylvestre → Bug 1688502 - Remove else if condition after break in layout/base/nsBidiPresUtils.cpp r=Sylvestre
Attachment #9200495 - Attachment is obsolete: true

Yeah got it. moz-phab is submitting revision to recent one. I want to submit this to the revision before recent one. As by mistake I created new revision https://phabricator.services.mozilla.com/D103701 but the revision which I want to update is https://phabricator.services.mozilla.com/D103596. How to tackle this situation.

please read the documentation.
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

this is explained

Attachment #9200495 - Attachment is obsolete: false
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a83c0d2c34e0
[Core] Remove else if condition after break in layout/base/nsBidiPresUtils.cpp#1338. r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Attachment #9200312 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.