1688510 - ApplicationReputation.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/7431701c98da9218fda314a54efa1a3093760f65/toolkit/components/reputationservice/ApplicationReputation.cpp#1332-1334

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[George White]

Attachment: Bug 1688510 - do not 'else' after 'return' in ApplicationReputation.cpp

Removed the 'else' statement to resolve clang-tidy warning.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/566ad2daef0b
do not 'else' after 'return' in ApplicationReputation.cpp r=sylvestre

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/566ad2daef0b