1688590 - WebSocket payload preview broken

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am not seeing preview for WS JSON payload that contains "data" field.

STR:

1. Load http://janodvarko.cz/test/websockets/
2. Open the Network panel
3. Click "Connect" button on the page
4. Try to send some messages (just to have something in the list of frames to select)
5. Select the 101 HTTP request and select the Response panel
6. Put the following string into the Send input field and click the "Send" button
   { "data": { } }
7. Select the WS frame in the Response panel -> the payload preview section is not updated BUG

ER:
The payload preview section should be properly updated when the use selects a frame in the list.

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks Honza!
I can reproduce it. I get this error TypeError: payloadUnclean.match is not a function. It might relate to this https://phabricator.services.mozilla.com/D80720

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The fix should be uplifted to beta when properly tested in Nightly.

Honza

Comment 4

[Hubert Boma Manilla (:bomsy)]

After more investigation, we hit the issue mentioned in this comment

https://bugzilla.mozilla.org/show_bug.cgi?id=1590046#c18

We have a loose rule in determining if the json payload is an Action Cable or not. https://searchfox.org/mozilla-central/rev/69babd862de70cabfa1d0a369d38e4881bd41e4d/devtools/client/netmonitor/src/components/messages/MessagePayload.js#291-293

The fix was a bit tricky so i guess a compromise was made here

https://bugzilla.mozilla.org/show_bug.cgi?id=1590046#c21

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1688590 - Use more specific rules to determine 'action cable' payloads r=honza

Identifying json Action cable payloads is tricky. Currently we parse the json again in parseActionCable to determine if
it is an Action cable payload.

Instead lets check using a possible criteria before attempting to call parseActionCable.
See https://medium.com/codequest/actioncable-in-rails-api-f087b65c860d for Action cable details.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfe7c77efb78
Use more specific rules to determine 'action cable' payloads r=Honza

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dfe7c77efb78

Comment 8

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9199348 [details]
Bug 1688590 - Use more specific rules to determine 'action cable' payloads r=honza

Beta/Release Uplift Approval Request

• User impact if declined: Impacts only developers
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small JavaScript change, with tests included
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9199348 [details]
Bug 1688590 - Use more specific rules to determine 'action cable' payloads r=honza

Low risk, has tests, approved for 86 beta 6, thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/98952bedcdf5