Closed Bug 1688605 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27308 - [testharness.js] Fix AssertRecord bug for asserts in setup in workers

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27308
Details from upstream follow.

b'Stephen McGruer <smcgruer@chromium.org>' wrote:

[testharness.js] Fix AssertRecord bug for asserts in setup in workers

If a setup function has an assert, then assert.test will be null. For
RemoteContext, we assumed that this wasn't the case (to read
test.index), and so we would throw an exception if someone asserted in a
setup function.

Fixes https://www.github.com/web-platform-tests/wpt/issues/27299

PR 27308 applied with additional changes from upstream: 934077ad8594041ef09a19181434f32c10c34d20, 7217e443c66461350204832d6c4f05d02f0cfbe1
PR 27308 applied with additional changes from upstream: 934077ad8594041ef09a19181434f32c10c34d20, 7217e443c66461350204832d6c4f05d02f0cfbe1, ddb7079f2e7612db30e9cb3611e9662909a657f8, 6421f622c7c9fd3dac94d0d3256fed61a073a676
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e897da2b692d
[wpt PR 27308] - [testharness.js] Fix AssertRecord bug for asserts in setup in workers, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e897da2b692d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.