Closed Bug 1688606 Opened 4 years ago Closed 4 years ago

bootstrap fails on (some?) windows because install-moz-phab exits with an error

Categories

(Firefox Build System :: Bootstrap Configuration, task, P3)

task

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: emilio, Assigned: mhentges)

References

Details

Attachments

(3 files)

I've seen this reported lately a few times by new Windows contributors. It seems we're hitting this code.

Do you have any idea of what might be going on? Maybe it should fail more gracefully?

Flags: needinfo?(mhentges)
Assignee: nobody → mhentges
Status: NEW → ASSIGNED
Flags: needinfo?(mhentges)
Priority: -- → P3
See Also: → 1689647

The second screenshot is related to 1689647.

The first screenshot is still a valid bug. I can reproduce it on a fresh Windows VM - ./mach install-moz-phab fails because it "Could not find the CLI script for moz-phab", and ./mach bootstrap thinks this is a fatal error and fully aborts.

Strangely, moz-phab is on the path, so the mechanism that ./mach install-moz-phab is using to find the binary is failing.

On Windows, when moz-phab is installed, two "executable" files are
created:

  • moz-phab.exe
  • moz-phab-script.py

Our moz-phab.exe detection was choking on moz-phab-script.py and was
unsure which of the two to use.

Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88c5e3e65b4b Improve moz-phab finding to avoid "moz-phab-script.py" r=firefox-build-system-reviewers,sheehan,glandium
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: