1688609 - [FR][fnac.com] Credit Card autofill/preview will does not work on pre-filled Name field

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: fnac.com.mov

Affected Versions:

• All latest Firefox versions using force enable (Nightly 86, Beta RC 85.0, Release 84.0.2)

Tested on:

• MacOS 10.15
• Windows 10 x64

Prerequisites:

• browser.search.region FR
• extensions.formautofill.supportedCountries FR
• download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to Reproduce:

1. Launch Firefox
2. Go to and reach the payment form for fnac.com
3. Click on each field to toggle the autofill dropdown

• clear out the prefilled Name field -

4. Check the preview for each field
5. Select 1 saved entry and check autofill
6. Type in manually 1 CC info and submit the form

Expected Results:
CC autofill should work correctly for all fields.

Actual Results:

1. Due to site pre-fill behavior, the Cardholder Name field will not toggle the autofill dropdown nor be autofilled
2. Previews will overlap placeholders
3. The Save Doorhanger will not capture the Cardholder Name.

Notes:

• Severity: S3 given this is not reproducible on Chrome
• Reproducible on Chrome?: No
• Regression-range: reproducible on all latest versions, this site was never tested before, can look for regression-range if need be

Comment 1

[Tim Giles [:tgiles]]

This is probably the same as Bug 1687684, where we don't autofill on fields that have a value when autofilling. I'm not going to close as a dupe since we should verify this site when a patch lands for either bug.

Comment 2

[Tim Giles [:tgiles]]

Hey :tbabos, now that Bug 1687684 has landed, could you verify that this bug is no longer reproducible? Thanks!

Comment 3

[Timea Cernea [:tbabos][inactive]]

Hey Tim, unfortunately, this is still reproducible on the latest Firefox Nightly 93.0a1 (2021-09-05) using the same scenario.
The Cardholder Name is pre-filled by the site and won't be auto-filled by our feature nor toggle the CC dropdown. This seems to be a different case from Bug 1687684, which I also verified and confirmed as fixed.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Attachment: 93.0a1 (2021-09-05)

Comment 5

[Tim Giles [:tgiles]]

On it, thanks for the report Timea!

Comment 6

[Tim Giles [:tgiles]]

Okay, the issue seems to be that we don't correctly identify the cardholder name field. The first pass solution I've discovered is adding "Titulaire" to our cc-name heuristic in heuristicsRegexp.js. This seems to fix both of the issues related to this bug and doesn't cause any tests to immediately fail (on my machine at least). I'm not sure if adding "Titulaire" is the perfect long-term solution, but it might be good enough for now.

Comment 7

[Tim Giles [:tgiles]]

Attachment: Bug 1688609 - Add 'titulaire' to cc-name heuristic regex. r=dimi,sfoster

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/207f9700cc3a
Add 'titulaire' to cc-name heuristic regex. r=dimi

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/207f9700cc3a

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tgiles, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Tim Giles [:tgiles]]

Credit card autofill is not yet enabled in FR locales, so wontfix on beta.

Comment 12

[Monica Chiorean]

I was able to reproduce the issue on Win10 (93.0).
Verified as fixed on Win10/Ubuntu 20.4 and Mac 10.15 (Beta 94.0b4).