1688665 - QuotaCleaner deleteByPrincipal over-clears sessionStorage and legacy localStorage

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P2)

Description

[Paul Zühlcke [:pbz]]

QuotaCleaner#deleteByPrincipal over-clears sessionStorage and legacy localStorage.

It only passes a host here:
https://searchfox.org/mozilla-central/rev/4dac9993b609fccc87e82682614faf2a44cda306/toolkit/components/cleardata/ClearDataService.jsm#473,480
This means that the StorageObserver will clear all localStorage and sessionStorage for a host, without taking origin attributes into account:
https://searchfox.org/mozilla-central/rev/4dac9993b609fccc87e82682614faf2a44cda306/dom/storage/StorageObserver.cpp#294,316

Looking at the interface, it seems that the legacy implementation does not support clearing by full origin: https://searchfox.org/mozilla-central/rev/4dac9993b609fccc87e82682614faf2a44cda306/dom/storage/PBackgroundStorage.ipdl#51

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1688665 - Support for clearing sessionStorage and legacy localStorage by principal. r=#dom-storage-reviewers

This patch introduces two new observer notifications for clearing sessionStorage and legacy localStorage
by principal / exact origin. This is a requirement for the Clear-Site-Data header which allows sites to clear
storages. For privacy reasons, it's important that a site can only clear the exact storage scope it has access to.
nsIClearDataService will call observer notifications to clear by principal, which are consumed by the
StorageObserver. StorageObserver will forward these messages to SessionStorageManager and LocalStorageManager.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1688665 - Updated tests for clearing localStorage and sessionStorage by principal. r=#dom-storage-reviewers

Depends on D121639

Comment 3

[Paul Zühlcke [:pbz]]

The work here has been blocked on review for many months already. Since this plays an important part in supporting the ClearSiteData header when TCP/dFPI is enabled, I think it would be good to get it landed soon.

Andrew, Jan, could you or somebody from your team please take a look at the patches? They are relatively simple. Happy to connect via Zoom or Slack too if it's helpful. Thanks!

Comment 4

[Jens Stutte [:jstutte]]

Jan will get to this very soon, sorry for the delay.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1688665 - Support for clearing sessionStorage by principal; r=pbz

The original patch D121639 has been developed by pbz.

Depends on D139812

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1688665 - Updated tests for clearing localStorage and sessionStorage by principal; r=pbz

The original patch D121640 has been developed by pbz.

Depends on D139813

Comment 7

[Jan Varga [:janv]]

Attachment: interdiff1.diff

Comment 8

[Jan Varga [:janv]]

Attachment: interdiff2.diff

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8010a4d4ffc9
Support for clearing sessionStorage by principal; r=pbz
https://hg.mozilla.org/integration/autoland/rev/d9329294168f
Updated tests for clearing localStorage and sessionStorage by principal; r=pbz

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8010a4d4ffc9
https://hg.mozilla.org/mozilla-central/rev/d9329294168f