Closed Bug 1688683 Opened 3 years ago Closed 3 years ago

New Tab: personlize button overlaps search bar at certain screen sizes

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox86 --- verified
firefox87 --- verified

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When resizing the screen, sometimes the search bar and the personalize button overlap. We need some more work here to make the button properly responsive.

Adding myself and verdi to cc for visibility

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc61f7883572
Personalize button and search should not overlap. r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Regressions: 1689905

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (87.0a1 Build ID - 20210131211743) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the "Personalize" button no longer overlaps the in-content "Search Bar" if the browser is resized.

Status: RESOLVED → VERIFIED

Comment on attachment 9199598 [details]
Bug 1688683 - Personalize button and search should not overlap.

Beta/Release Uplift Approval Request

  • User impact if declined: When the newtab experiencee is flipped on, on certain screen sizes the search bar and the personaliz button will overlap.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS only patch. All code is behind a pref which will be turned on for expriments.
  • String changes made/needed: none
Attachment #9199598 - Flags: approval-mozilla-beta?

Comment on attachment 9199598 [details]
Bug 1688683 - Personalize button and search should not overlap.

Approved for 86 beta 6, thanks.

Attachment #9199598 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0b6 Build ID - 20210204185843) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the "Personalize" button no longer overlaps the in-content "Search Bar" if the browser is resized.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: