Closed Bug 1688778 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27319 - [testharness.js] Respect properties.output in assert_wrapper

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27319 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27319
Details from upstream follow.

b'Stephen McGruer <smcgruer@chromium.org>' wrote:

[testharness.js] Respect properties.output in assert_wrapper

The method was using settings.output to determine if visual output was
enabled. It then performed an expensive operation only if it was.
However, settings.output is not updated even if 'output' is
specified in a call to setup(..) from the testharnessreport.js, as the
'settings' object is meant to outlive different setups (it seems).

This change adds an output member to the Tests object, which is
initialized from settings.output and then updated by setup(..). We
may want a slightly different fix long-term, but this bug is suspected
of causing a 33% performance regression on Chromium MSAN bots, so we
need something quick!

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream error] → [wptsync downstream]
You need to log in before you can comment on or make changes to this bug.