[wpt-sync] Sync PR 27320 - [testharness.js] Respect properties.output in assert_wrapper
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox87 fixed)
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 27320 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/27320
Details from upstream follow.
b'Stephen McGruer <smcgruer@chromium.org>' wrote:
[testharness.js] Respect properties.output in assert_wrapper
The method was using settings.output to determine if visual output was
enabled. It then performed an expensive operation only if it was.
However, settings.output is not updated even if 'output' is
specified in a call to setup(..) from the testharnessreport.js, as the
'settings' object is meant to outlive different setups (it seems).This change adds an output member to the Tests object, which is
initialized from settings.output and then updated by setup(..). We
may want a slightly different fix long-term, but this bug is suspected
of causing a 33% performance regression on Chromium MSAN bots, so we
need something quick!Bug: 1170588
Change-Id: I4d461b846a8cc718d6f8988e5cfec93effa8100aReviewed-on: https://chromium-review.googlesource.com/2648201
WPT-Export-Revision: 903e2f9d352842b4fec265f908ee650e0b8843ea
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=efd9fe94fe1ff303f4b63b8d9dd8c1335321886a
Assignee | ||
Comment 2•3 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e3e6101ca61 [wpt PR 27320] - [testharness.js] Respect properties.output in assert_wrapper, a=testonly
Comment 4•3 years ago
|
||
bugherder |
Description
•