1688786 - Add a browser.urlbar.showSearchSuggestionsFirst pref

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

In https://phabricator.services.mozilla.com/D99281 (bug 1676469), Marco suggested it would be a good idea to add a shouldShowSuggestionsBeforeGeneralResults pref so that we uncouple that behavior from matchBuckets/resultBuckets. See:

• https://phabricator.services.mozilla.com/D99281#inline-575043
• https://phabricator.services.mozilla.com/D99281#inline-575145

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1688786 - Add a browser.urlbar.showSearchSuggestionsFirst pref.

Introduce a new browser.urlbar.showSuggestionsBeforeGeneral boolean pref that
determines whether search suggestions are shown before general results.

This keeps the matchBuckets pref. I could have removed it since the only thing
we're using it for right now is to tell whether suggestions are shown first. The
reason I didn't remove it is because ultimately we do want a matchBuckets or
resultBuckets pref so we can experiment with different results compositions
using simple pref-flip studies. Hopefully bug 1676469 will land soon and we'll
replace matchBuckets with resultBuckets, but in the meantime I think we
should keep matchBuckets around.

This also removes some browser.urlbar.matchBuckets assignments in tests that
don't actually depend on it. For tests that do depend on it, I changed them so
they set showSuggestionsBeforeGeneral now.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0868dc5276ec5b07d696b333d100f992c36197b0

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3434ffda7be5381139b154f830a3ebf402c14493

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/666ef27d61bd
Add a browser.urlbar.showSearchSuggestionsFirst pref. r=mak,preferences-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/666ef27d61bd