Closed Bug 1688786 Opened 2 years ago Closed 2 years ago

Add a browser.urlbar.showSearchSuggestionsFirst pref

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
3

Tracking

()

RESOLVED FIXED
87 Branch
Iteration:
87.1 - Jan 25 - Feb 7
Tracking Status
firefox87 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

In https://phabricator.services.mozilla.com/D99281 (bug 1676469), Marco suggested it would be a good idea to add a shouldShowSuggestionsBeforeGeneralResults pref so that we uncouple that behavior from matchBuckets/resultBuckets. See:

Introduce a new browser.urlbar.showSuggestionsBeforeGeneral boolean pref that
determines whether search suggestions are shown before general results.

This keeps the matchBuckets pref. I could have removed it since the only thing
we're using it for right now is to tell whether suggestions are shown first. The
reason I didn't remove it is because ultimately we do want a matchBuckets or
resultBuckets pref so we can experiment with different results compositions
using simple pref-flip studies. Hopefully bug 1676469 will land soon and we'll
replace matchBuckets with resultBuckets, but in the meantime I think we
should keep matchBuckets around.

This also removes some browser.urlbar.matchBuckets assignments in tests that
don't actually depend on it. For tests that do depend on it, I changed them so
they set showSuggestionsBeforeGeneral now.

Attachment #9199436 - Attachment description: Bug 1688786 - Add a browser.urlbar.shouldShowSuggestionsBeforeGeneralResults pref. → Bug 1688786 - Add a browser.urlbar.showSearchSuggestionsFirst pref.
Summary: Add a shouldShowSuggestionsBeforeGeneralResults pref → Add a browser.urlbar.showSearchSuggestionsFirst pref
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/666ef27d61bd
Add a browser.urlbar.showSearchSuggestionsFirst pref. r=mak,preferences-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.